This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
[Preview] Don't allow popover to move outside editor boundaries #6654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
changed the title
|
Superceded by #6654 |
|
Do'h, closed wrong PR |
jasonLaster
reviewed
Jul 17, 2018
| this.state = { | ||
| top: 0 | ||
| }; | ||
| } |
There was a problem hiding this comment.
I wonder if this can be:
export class Popup extends Component<Props, State> {
// stuff
state: State = { top: 0 }
// stuff
jasonLaster
reviewed
Jul 17, 2018
| @@ -5,12 +5,9 @@ | |||
| .popover .preview-popup { | |||
| background: var(--theme-body-background); | |||
| width: 350px; | |||
| min-height: 80px; | |||
There was a problem hiding this comment.
why don't we need a min?
There was a problem hiding this comment.
Because we don't want this:
There was a problem hiding this comment.
Also note that this 80px min wasn't even used; it was overridden lower in the same selector :)
jasonLaster
approved these changes
Jul 17, 2018
|
The saga continues with the test failure. I stubbed in a noop function for |
jasonLaster
reviewed
Jul 18, 2018
| <div | ||
| className="gap" | ||
| key="gap" | ||
| /> | ||
| <h1> | ||
| Toolie! | ||
| </h1> |
There was a problem hiding this comment.
not sure if this moving is a big deal
jasonLaster
pushed a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #5134
Supercedes #6537