Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Able to blackbox a script from multiple places WIP #7335

Closed
wants to merge 4 commits into from

Conversation

Doomwyte
Copy link
Contributor

Fixes #7287 WIP

Summary of Changes

  • Blackbox a script from the sources panel WIP

Screenshots/Videos

screen shot 2018-11-22 at 5 20 35 pm

@Doomwyte
Copy link
Contributor Author

I need some help with adding the blackbox source menu item to the sources panel.

I added some console.log() in my commit to illustrate my issue. I got the menu item to appear in the sources panel, but clicking on it does not do anything. I found out that it's because in blackbox.js, it does not go into the return async() part inside function toggleBlackBox(). I notice that when I try doing the blackbox source action from right clicking in the source content, it does go into return async(). So I'm not sure why when I do it from the sources panel, it does not work.

@AnshulMalik
Copy link
Contributor

I see that you are importing the action from actions file and directly calling it. One of my friends did the same thing yesterday and we lost two hours debugging the same :P.

You should bind the action like these and use it from props.

@Doomwyte
Copy link
Contributor Author

Awesome I'll give that a try, thanks!

@Doomwyte
Copy link
Contributor Author

Clicking on blackbox source in the sources panel now works. However, it does not update and I am unable to unblackbox the source through the sources panel without refreshing the page. Working on it.

@darkwing
Copy link
Contributor

darkwing commented Dec 5, 2018

This is awesome research into the issue @Doomwyte ! I think we'll close for now because our context menu system needs a lot of work and consolidation. I'll keep this in mind!

@darkwing darkwing closed this Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants