This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
pretty print exception bug #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainsneha23
force-pushed
the
bug-7477-pretty-print-exception
branch
from
1a9bd45
to
21c5366
Compare
|
Note: This error got introduced in this commit 4a43e9a After introducing flow, line number for SourceLocation has to be a number. If set to zero, it throws the current error. If set to 1, there's a flash at line 1 while opening a file in the editor. NaN seems to be a workaround, but doesn't make any sense. So setting it as 1 for now. May be we need to handle the flash somehow. |
|
This looks good. CC @darkwing |
|
Looking good 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7477
Summary of Changes
Test Plan