Bug 7571 - set directory root for debugger.html #7594

jainsneha23 · 2018-12-25T07:53:09Z

Fixes #7571

Summary of Changes

fix for absolute paths

jainsneha23 · 2018-12-25T07:53:28Z

The code needs refactoring

jasonLaster

Could we add a test in addToTree.spec.js or another relevant file?

jasonLaster · 2018-12-26T05:12:16Z

So, I believe we started using whatwg-url for this reason last month here.

https://www.npmjs.com/package/whatwg-url

I wonder if using this library would give us a more spec compliant URL parse that would help us...

jainsneha23 · 2018-12-26T05:24:30Z

So, I believe we started using whatwg-url for this reason last month here.

https://www.npmjs.com/package/whatwg-url

I wonder if using this library would give us a more spec compliant URL parse that would help us...

Thanks . Will look into this , if It can help. This solution is hacky and I need to refactor this to have more robust solution.

jainsneha23 · 2018-12-26T11:10:47Z

src/utils/sources-tree/getURL.js

    case "ng:":
+    case "webpack:":
+      const path = pathname.substring(2);


using whatwg-url will automatically do this. Can I introduce that module in src/utils/url.js ?

Yea, we can try that

jainsneha23 · 2018-12-26T11:18:49Z

@jasonLaster This is better than what I did before. Also fixes the absolute path for https://w2x2oypmqk.codesandbox.io/

Still I am not completely satisfied here. The way to create directory has to change if the url is from webpack. Check chrome's webpack folder. It creates folders based on webpack paths. Check image attached. I think we need to re-think on webpack tree. What are your thoughts on this?

Note: Will add unit tests for webpack, once I am done with the exact output that we want.

jasonLaster · 2018-12-27T03:52:29Z

@jainsneha23 can you give some more examples of the differences between chrome and firefox? I'm not sure I follow...

Also, could you share the whatwg example, either by pushing it to this branch or by sharing another branch.

by the way, @loganfsmyth is our path expert and will be back on monday.

jainsneha23 · 2018-12-27T11:16:46Z

@jasonLaster

Find the screeshot below on the difference on how node and whatwg handles URL differently.

With protocols ending with :// for webpack and ng, node URL doesn't seem to return correct path. There are extra slashes. So, using whatwg URL is better.

Also we have URLs like

webpack:///../../abc (2 level up than where the webpack config is)
webpack:////Users/abc (absolute path)
webpack:///abc/def (same directory as the webpack config)

The screenshot above shows how chrome creates folders with . .. for level up folders

But in our source-map, we trim all the dots. So, that is not achievable right now. But the path for absolute paths is fixed. I have to fix the unit test though. Will do it tomorrow.

May be we can think on should we handle the level up folders for webpack, and raise a separate issue for the same. As that will require changes in source-map as well.

loganfsmyth

I think my questions on this are really more about the existing architecture, but the big question to me is, why aren't these source URLs already absolute? It seems like we should aim to have an absolute URL computed up front for all sources, and if we have that, the WHATWG URL API pretty much provides everything else we need, and we can avoid pretty much all of the logic in _getURL.

loganfsmyth · 2019-01-02T22:16:31Z

src/utils/sources-tree/getURL.js

      return {
        ...def,
        path: pathname,
        filename,
-        group: `${protocol}//`
+        group: `${protocol}//`,
+        isAbsolutePath: pathname.startsWith("//")


This doesn't seem right to me, if we're using WHATWG URL to process this, it should just be a single slash.

@loganfsmyth For webpack, we can have urls with double slash, and dots
Please find some webpack urls below:

webpack:///webpack/bootstrap fc4578a0bef29d2a63f3
webpack:///src/component/index.js
webpack:////Users/workspace/github/debugger.html/node_modules/react/index.js
webpack:///./utils/debug.js
webpack:///../node_modules/devtools-environment/test-flag.js

In these examples, with whatwg-url, the pathname should be

/webpack/bootstrap fc4578a0bef29d2a63f3

/src/component/index.js

//Users/workspace/github/debugger.html/node_modules/react/index.js

/utils/debug.js

/node_modules/devtools-environment/test-flag.js

what is throwing me off here is these are already all absolute because they start with a single slash.

@loganfsmyth
Yes with whatwg-url the pathname are as you mentioned. What I meant by absolute was system absolute path.

If you see, all other paths are relative to the debugger.html folder. And only this path //Users/workspace/github/debugger.html/node_modules/react/index.js is system absolute path.

In webpack, the paths are file paths in system, and either they are relative to the path from where the webpack was run like the other 4, or absolute system path.

And this issue raised happened only for the system absolute path. I was also able to see the same issue in https://w2x2oypmqk.codesandbox.io/

Sorry for miscommunication. And we can have a quick chat on this today evening if you want.

I think part of what is tripping me up is, aren't those examples just mistakes on the part of Webpack? All URLs like this are absolute. The fact that there is a double slash at the start of one of them just means that one of the path segments is an empty string. It seems like a mistake in whatever configuration generated that URL. It seems unreasonable to expect the devtools to try to interpret what is essentially bad data.

With URLs as

webpack:///webpack/bootstrap fc4578a0bef29d2a63f3 webpack:///src/component/index.js webpack:////Users/workspace/github/debugger.html/node_modules/react/index.js webpack:///./utils/debug.js webpack:///../node_modules/devtools-environment/test-flag.js

I'd expect that the folder structure would be

Webpack (webpack://) * "webpack" * "bootstrap fc4578a0bef29d2a63f3" * "src" * "components" * "index.js" * "" * "Users" * "workspace" * "github" * "debugger.html" * "node_modules" * "react" * "index.js" * "utils" * "debug.js" * "node_modules" * "devtools-enviroment" * "test-flag.js"

loganfsmyth · 2019-01-02T22:17:49Z

src/utils/sources-tree/getURL.js

      return {
        ...def,
        path: pathname,
        filename,
-        group: `${protocol}//`
+        group: `${protocol}//`,


I'm surprised that this doesn't include the hostname. How that we've got WHATWG URL, I'd have expected more of the logic in this function to collapse into

group: `${protocol}//${host || ""}`

jasonLaster · 2019-01-03T14:07:40Z

@jainsneha23 I wonder how well whatwg does in general...

could you try running getURL without all of the special cases and share some findings?

diff --git a/src/utils/sources-tree/getURL.js b/src/utils/sources-tree/getURL.js
index 42e1f5227..055912b19 100644
--- a/src/utils/sources-tree/getURL.js
+++ b/src/utils/sources-tree/getURL.js
@@ -39,82 +39,7 @@ function _getURL(source: Source, defaultDomain: string): ParsedURL {

   const { pathname, protocol, host } = parse(url);
   const filename = getUnicodeUrlPath(getFilenameFromPath(pathname));
-
-  switch (protocol) {
-    case "javascript:":
-      // Ignore `javascript:` URLs for now
-      return def;
-
-    case "moz-extension:":
-    case "resource:":
-      return {
-        ...def,
-        path: pathname,
-        filename,
-        group: `${protocol}//${host || ""}`
-      };
-
-    case "webpack:":
-    case "ng:":
-      return {
-        ...def,
-        path: pathname,
-        filename,
-        group: `${protocol}//`
-      };
-
-    case "about:":
-      // An about page is a special case
-      return {
-        ...def,
-        path: "/",
-        filename,
-        group: url
-      };
-
-    case "data:":
-      return {
-        ...def,
-        path: "/",
-        group: NoDomain,
-        filename: url
-      };
-
-    case "":
-      if (pathname && pathname.startsWith("/")) {
-        // use file protocol for a URL like "/foo/bar.js"
-        return {
-          ...def,
-          path: pathname,
-          filename,
-          group: "file://"
-        };
-      } else if (!host) {
-        return {
-          ...def,
-          path: url,
-          group: defaultDomain || "",
-          filename
-        };
-      }
-      break;
-
-    case "http:":
-    case "https:":
-      return {
-        ...def,
-        path: pathname,
-        filename,
-        group: getUnicodeHostname(host)
-      };
-  }
-
-  return {
-    ...def,
-    path: pathname,
-    group: protocol ? `${protocol}//` : "",
-    filename
-  };
+  return { ...def, pathname, protocol, host, filename };
 }

jasonLaster · 2019-01-03T14:08:49Z

By the way, as you can probably tell... this is somewhat of a scary change so it will likely move pretty slow as we try to sort out all of the different scenarios. Thanks (in advance) for your patience :)

jainsneha23 · 2019-01-07T11:23:51Z

Here are some differences listed (we can ignore node url for now, as this happens on the browser). Also notice the difference in chrome and firefox. SO, better to use WHATWG for consistency

WHATWG URL:   const URL = require(whatwg-url).URL; new URL(urlstring)
NODE:   const URL = require(url); URL.parse(urlstring)
BROWSER:  new URL(urlstring)

URL	USING WHATWG URL	USING NODE URL	USING CHROME URL	USING FIREFOX NIGHTLY URL
javascript:alert(1)	url: javascript:alert(1)	url: javascript:alert(1)	url: javascript:alert(1)	url: javascript:alert(1)
	protocol: javascript:	protocol: javascript:	protocol: javascript:	protocol: javascript:
	host:	host: null	host:	host:
	pathname: alert(1)	pathname: alert(1)	pathname: alert(1)	pathname: alert(1)
	filename: (index)	filename: (index)	filename: (index)	filename: (index)

moz-extension:kasjdkasdjklasjdlk	url: moz-extension:kasjdkasdjklasjdlk	url: moz-extension:kasjdkasdjklasjdlk	url: moz-extension:kasjdkasdjklasjdlk	url: moz-extension:kasjdkasdjklasjdlk
	protocol: moz-extension:	protocol: moz-extension:	protocol: moz-extension:	protocol: moz-extension:
	host:	host: kasjdkasdjklasjdlk	host:	host: kasjdkasdjklasjdlk
	pathname: kasjdkasdjklasjdlk	pathname: null	pathname: kasjdkasdjklasjdlk	pathname: /
	filename: (index)	filename:	filename: (index)	filename: (index)

resource://gre/res/svg.css	url: resource://gre/res/svg.css	url: resource://gre/res/svg.css	url: resource://gre/res/svg.css	url: resource://gre/res/svg.css
	protocol: resource:	protocol: resource:	protocol: resource:	protocol: resource:
	host: gre	host: gre	host:	host: gre
	pathname: /res/svg.css	pathname: /res/svg.css	pathname: //gre/res/svg.css	pathname: /res/svg.css
	filename: svg.css	filename: svg.css	filename: svg.css	filename: svg.css

webpack:///abc/index.js	url: webpack:///abc/index.js	url: webpack:///abc/index.js	url: webpack:///abc/index.js	url: webpack:///abc/index.js
	protocol: webpack:	protocol: webpack:	protocol: webpack:	protocol: webpack:
	host:	host:	host:	host:
	pathname: /abc/index.js	pathname: /abc/index.js	pathname: ///abc/index.js	pathname: ///abc/index.js
	filename: index.js	filename: index.js	filename: index.js	filename: index.js

webpack:////abc/index.js	url: webpack:////abc/index.js	url: webpack:////abc/index.js	url: webpack:////abc/index.js	url: webpack:////abc/index.js
	protocol: webpack:	protocol: webpack:	protocol: webpack:	protocol: webpack:
	host:	host:	host:	host:
	pathname: //abc/index.js	pathname: //abc/index.js	pathname: ////abc/index.js	pathname: ////abc/index.js
	filename: index.js	filename: index.js	filename: index.js	filename: index.js

ng:///abc/index.js	url: ng:///abc/index.js	url: ng:///abc/index.js	url: ng:///abc/index.js	url: ng:///abc/index.js
	protocol: ng:	protocol: ng:	protocol: ng:	protocol: ng:
	host:	host:	host:	host:
	pathname: /abc/index.js	pathname: /abc/index.js	pathname: ///abc/index.js	pathname: ///abc/index.js
	filename: index.js	filename: index.js	filename: index.js	filename: index.js

about:config	url: about:config	url: about:config	url: about:config	url: about:config
	protocol: about:	protocol: about:	protocol: about:	protocol: about:
	host:	host: config	host:	host:
	pathname: config	pathname: null	pathname: config	pathname: config
	filename: (index)	filename:	filename: (index)	filename: (index)

http://firefox.com	url: http://firefox.com	url: http://firefox.com	url: http://firefox.com	url: http://firefox.com
	protocol: http:	protocol: http:	protocol: http:	protocol: http:
	host: firefox.com	host: firefox.com	host: firefox.com	host: firefox.com
	pathname: /	pathname: /	pathname: /	pathname: /
	filename: (index)	filename: (index)	filename: (index)	filename: (index)

https://firefox.com	url: https://firefox.com	url: https://firefox.com	url: https://firefox.com	url: https://firefox.com
	protocol: https:	protocol: https:	protocol: https:	protocol: https:
	host: firefox.com	host: firefox.com	host: firefox.com	host: firefox.com
	pathname: /	pathname: /	pathname: /	pathname: /
	filename: (index)	filename: (index)	filename: (index)	filename: (index)

data:text/html,	url: data:text/html,	url: data:text/html,	url: data:text/html,	url: data:text/html
	protocol: data:	protocol: data:	protocol: data:	protocol: data:
	host:	host: text	host:	host:
	pathname: text/html,	pathname: /html,%20%3Chtml%20contenteditable%3E	pathname: text/html,	pathname: text/html
	filename: (index)	filename: (index)	filename: (index)	filename: (index)

/foo/bar.js	url: /foo/bar.js	url: /foo/bar.js	url: /foo/bar.js	url: /foo/bar.js
	protocol:	protocol: null	protocol:	protocol:
	host:	host: null	host:	host:
	pathname: /foo/bar.js	pathname: /foo/bar.js	pathname: /foo/bar.js	pathname: /foo/bar.js
	filename: bar.js	filename: bar.js	filename: bar.js	filename: bar.js

//cdn.ajax.com/react.js	url: //cdn.ajax.com/react.js	url: //cdn.ajax.com/react.js	url: //cdn.ajax.com/react.js	url: //cdn.ajax.com/react.js
	protocol:	protocol: null	protocol:	protocol:
	host:	host: null	host:	host:
	pathname: //cdn.ajax.com/react.js	pathname: //cdn.ajax.com/react.js	pathname: //cdn.ajax.com/react.js	pathname: //cdn.ajax.com/react.js
	filename: react.js	filename: react.js	filename: react.js	filename: react.js

file://foo/bar.js	url: file://foo/bar.js	url: file://foo/bar.js	url: file://foo/bar.js	url: file://foo/bar.js
	protocol: file:	protocol: file:	protocol: file:	protocol: file:
	host: foo	host: foo	host: foo	host:
	pathname: /bar.js	pathname: /bar.js	pathname: /bar.js	pathname: /bar.js
	filename: bar.js	filename: bar.js	filename: bar.js	filename: bar.js

urn:isbn:9780141036144	url: urn:isbn:9780141036144	url: urn:isbn:9780141036144	url: urn:isbn:9780141036144	url: urn:isbn:9780141036144
	protocol: urn:	protocol: urn:	protocol: urn:	protocol: urn:
	host:	host: isbn:9780141036144	host:	host:
	pathname: isbn:9780141036144	pathname: null	pathname: isbn:9780141036144	pathname: isbn:9780141036144
	filename: (index)	filename:	filename: (index)	filename: (index)

tel:+1-816-555-1212	url: tel:+1-816-555-1212	url: tel:+1-816-555-1212	url: tel:+1-816-555-1212	url: tel:+1-816-555-1212
	protocol: tel:	protocol: tel:	protocol: tel:	protocol: tel:
	host:	host: +1-816-555-1212	host:	host:
	pathname: +1-816-555-1212	pathname: null	pathname: +1-816-555-1212	pathname: +1-816-555-1212
	filename: (index)	filename:	filename: (index)	filename: (index)

git@github.com:mdn/browser-compat-data.git	url: git@github.com:mdn/browser-compat-data.git	url: git@github.com:mdn/browser-compat-data.git	url: git@github.com:mdn/browser-compat-data.git	url: git@github.com:mdn/browser-compat-data.git
	protocol:	protocol: null	protocol:	protocol:
	host:	host: null	host:	host:
	pathname:git@github.com:mdn/browser-compat-data.git	pathname: git@github.com:mdn/browser-compat-data.git	pathname:git@github.com:mdn/browser-compat-data.git	pathname:git@github.com:mdn/browser-compat-data.git
	filename: browser-compat-data.git	filename: browser-compat-data.git	filename: browser-compat-data.git	filename: browser-compat-data.git

	url: ftp://example.org/resource.txt	url: ftp://example.org/resource.txt	url: ftp://example.org/resource.txt	url: ftp://example.org/resource.txt
ftp://example.org/resource.txt	protocol: ftp:	protocol: ftp:	protocol: ftp:	protocol: ftp:
	host: example.org	host: example.org	host: example.org	host: example.org
	pathname: /resource.txt	pathname: /resource.txt	pathname: /resource.txt	pathname: /resource.txt
	filename: resource.txt	filename: resource.txt	filename: resource.txt	filename: resource.txt

mailto:help@supercyberhelpdesk.info	url: mailto:help@supercyberhelpdesk.info	url: mailto:help@supercyberhelpdesk.info	url: mailto:help@supercyberhelpdesk.info	url: mailto:help@supercyberhelpdesk.info
	protocol: mailto:	protocol: mailto:	protocol: mailto:	protocol: mailto:
	host:	host: supercyberhelpdesk.info	host:	host:
	pathname:help@supercyberhelpdesk.info	pathname: null	pathname:help@supercyberhelpdesk.info	pathname:help@supercyberhelpdesk.info
	filename:help@supercyberhelpdesk.info	filename:	filename:help@supercyberhelpdesk.info	filename:help@supercyberhelpdesk.info

So, we will still need the special cases for javascript, about, data, and no protocol case (to handle file urls, and relative urls)

darkwing · 2019-01-30T14:49:02Z

src/utils/sources-tree/addToTree.js

@@ -86,8 +86,9 @@ function traverseTree(
  tree: TreeDirectory,
  debuggeeHost: ?string
 ): TreeNode {
-  const parts = url.path.split("/").filter(p => p !== "");
-  parts.unshift(url.group);
+  const parts = url.path.split("/").filter((p, i) => p !== "" || i < 2);


We should add a comment here as to what is going on.

@darkwing @loganfsmyth Do we really need this filter? Cannot we just render the path as is?

I agree that this filter seems unnecessary to me. My vote would be for

const parts = url.path.split("/"); if (parts[0] === "") parts.shift(); parts.unshift(url.group);

Looking over this again, I think we should just keep it simple and do

const parts = url.path.split("/"); parts.unshift(url.group);

and revisit after that.

@loganfsmyth Unfortunately the snippet you cited creates the following:

Alright, that's what I was worried about. Honestly, maybe the better approach would be to just leave the filter for now and change things more in a later pass?

@darkwing in davidwalsh.name, the empty folder you got was because of a path '/', which creates empty node. for this case, we can remove any trailing slash from a url.

otherwise this works fine. can you please have a look at my commit.

darkwing · 2019-01-30T14:49:57Z

@loganfsmyth Since you were the sourcemaps legend, I'd like your take on this; i.e. if this is a viable solution.

darkwing · 2019-02-05T18:58:05Z

Seeing this with the current code:

jasonLaster · 2019-02-05T20:22:03Z

@darkwing what is the test page?

darkwing · 2019-02-05T21:08:26Z

My blog, of course :D

darkwing · 2019-02-08T23:51:03Z

I played with this today and it's totally frustrating! I appreciate your efforts @jainsneha23!

I tried adding a regex to remove multiple / (url.path.replace(/\/{2,}/g, "/").split("/").filter......) and that wasn't helpful.
I commented out import { URL } from "whatwg-url"; from the url.js file and that didn't appear to make any visual change.

… into bug-7571-set-dir-root * 'master' of https://github.com/devtools-html/debugger.html: [Sources] Consolidate sources reducer (firefox-devtools#7977) Update maintainer.md (firefox-devtools#7973) Improve EventListener UI (firefox-devtools#7937)

jainsneha23 · 2019-02-19T11:36:56Z

@jasonLaster @darkwing The branch is rebased with latest master, and unit tests are updates for files with no filename, webpack urls, webpack url with system absolute path. Its ready for review.

jasonLaster · 2019-02-21T17:22:51Z

so... in terms of getting this library included in the debugger vendors...

There are a couple of steps:

adding it to vendors.js
updating copy-module.js which is in MC and not in github. This part means we will need to update MC first...

diff --git a/package.json b/package.json
index be1988695..77365dc2a 100644
--- a/package.json
+++ b/package.json
@@ -80,7 +80,8 @@
     "react-transition-group": "^2.2.1",
     "reselect": "^4.0.0",
     "svg-inline-react": "^3.0.0",
-    "wasmparser": "^0.7.0"
+    "wasmparser": "^0.7.0",
+    "whatwg-url": "..."
   },
   "private": true,
   "workspaces": [
diff --git a/src/vendors.js b/src/vendors.js
index 29660c0b2..bc7792280 100644
--- a/src/vendors.js
+++ b/src/vendors.js
@@ -28,6 +28,7 @@ import * as fuzzaldrinPlus from "fuzzaldrin-plus";
 import * as transition from "react-transition-group/Transition";
 import * as reactAriaComponentsTabs from "react-aria-components/src/tabs";
 import * as reselect from "reselect";
+import whatWg from "whatwg-url";

 // Modules imported without destructuring
 import classnames from "classnames";
@@ -55,5 +56,6 @@ export const vendored = {
   reselect,
   // Svg is required via relative paths, so the key is not imported path.
   // See .babel/transform-mc.js
-  Svg
+  Svg,
+  whatWg
 };

loganfsmyth · 2019-02-21T17:50:12Z

Functionally this seems good to me. The hard remaining part is definitely getting this into mozilla-central itself.

jasonLaster · 2019-02-21T21:05:47Z

I don't mind getting it into MC

darkwing · 2019-04-12T14:22:54Z

I'd like to get some closure here -- @loganfsmyth @jasonLaster What's the difficulty in getting this into mc?

jasonLaster · 2019-04-12T15:46:15Z

@darkwing I hope to do this next week

jasonLaster · 2019-05-22T19:58:33Z

Hey @jainsneha23 i'm sorry for the delay, i'm finally getting around to landing this in firefox

https://phabricator.services.mozilla.com/D31313

and ufortunately i'm seeing the original issue with the debugger directory. Did you see this as well when working on it or was your version fixed?

jainsneha23 · 2019-05-23T09:35:15Z

@jasonLaster hey my version was fixed. Can you elaborate on this? Then I will check. Are you seeing the error after rebasing it with current master? Or my branch itself gives the error?

jasonLaster · 2019-05-23T12:55:04Z

oh cool. Yeah, i copied your version in the phabricator branch. I would be really interested if this branch works when you rebase it...

jainsneha23 · 2019-05-23T13:15:02Z

Sure. I will rebase and check this weekend.

jasonLaster · 2019-05-23T18:03:55Z

done! https://phabricator.services.mozilla.com/D31313

jainsneha23 · 2019-05-25T04:34:03Z

great!! thanks @jasonLaster @darkwing @loganfsmyth

jasonLaster reviewed Dec 25, 2018

View reviewed changes

jainsneha23 commented Dec 26, 2018

View reviewed changes

jasonLaster added 📚 pr-needs-review and removed 📚 pr-needs-review labels Dec 27, 2018

jainsneha23 force-pushed the bug-7571-set-dir-root branch from e03edef to 7ba75e2 Compare December 28, 2018 10:34

loganfsmyth reviewed Jan 2, 2019

View reviewed changes

jainsneha23 force-pushed the bug-7571-set-dir-root branch from 7ba75e2 to 72d4b15 Compare January 4, 2019 16:31

darkwing added the 📚 pr-wip label Jan 10, 2019

darkwing reviewed Jan 30, 2019

View reviewed changes

loganfsmyth self-requested a review February 4, 2019 21:26

jainsneha23 force-pushed the bug-7571-set-dir-root branch from 8a904d1 to 8aa678b Compare February 13, 2019 09:28

darkwing force-pushed the bug-7571-set-dir-root branch from 8aa678b to 4b82043 Compare February 15, 2019 16:38

removing filter

50e878b

darkwing force-pushed the bug-7571-set-dir-root branch from 4b82043 to 50e878b Compare February 15, 2019 16:46

Jain, Sneha T added 2 commits February 19, 2019 13:53

add test for file with no filename, and webpack paths

cbdec18

darkwing assigned loganfsmyth Feb 28, 2019

jasonLaster closed this May 23, 2019

jainsneha23 deleted the bug-7571-set-dir-root branch May 25, 2019 04:34

Bug 7571 - set directory root for debugger.html #7594

Bug 7571 - set directory root for debugger.html #7594

Conversation

jainsneha23 commented Dec 25, 2018

Summary of Changes

jainsneha23 commented Dec 25, 2018

jasonLaster left a comment

Choose a reason for hiding this comment

jasonLaster commented Dec 26, 2018

jainsneha23 commented Dec 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jainsneha23 commented Dec 26, 2018

jasonLaster commented Dec 27, 2018 • edited Loading

jainsneha23 commented Dec 27, 2018 • edited Loading

loganfsmyth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasonLaster commented Jan 3, 2019

jasonLaster commented Jan 3, 2019

jainsneha23 commented Jan 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darkwing commented Jan 30, 2019

darkwing commented Feb 5, 2019

jasonLaster commented Feb 5, 2019

darkwing commented Feb 5, 2019

darkwing commented Feb 8, 2019 • edited Loading

jainsneha23 commented Feb 19, 2019

jasonLaster commented Feb 21, 2019

loganfsmyth commented Feb 21, 2019

jasonLaster commented Feb 21, 2019

darkwing commented Apr 12, 2019

jasonLaster commented Apr 12, 2019

jasonLaster commented May 22, 2019

jainsneha23 commented May 23, 2019

jasonLaster commented May 23, 2019

jainsneha23 commented May 23, 2019

jasonLaster commented May 23, 2019

jainsneha23 commented May 25, 2019

jasonLaster commented Dec 27, 2018 •

edited

Loading

jainsneha23 commented Dec 27, 2018 •

edited

Loading

jainsneha23 commented Jan 7, 2019 •

edited

Loading

darkwing commented Feb 8, 2019 •

edited

Loading