This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add a way to stop an ongoing project search #7621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the search operation is assigned a cancellation function that can be used to stop the search. Next, when a new search is started, it is saved in state so that it can later be cancelled. The ongoing search is cancelled when: - A new project search is started. - A user clicks the "x" button on the search input.
This action is not used.
AnshulMalik
reviewed
Jan 1, 2019
| await dispatch(clearSearchResults()); | ||
| await dispatch(addSearchQuery(query)); | ||
| dispatch(updateSearchStatus(statusType.fetching)); | ||
| const validSources = getSourceList(getState()).filter( | ||
| source => !hasPrettySource(getState(), source.id) && !isThirdParty(source) | ||
| ); | ||
| for (const source of validSources) { | ||
| if (cancelled) { | ||
| return; |
|
This is great! @Garee :) |
- Use ProjectTextSearch selectors - Rename 'search' state to 'ongoingSearch' - Move stopOngoingSearch() into searchSources() and closeProjectSearch()
AnshulMalik
reviewed
Jan 1, 2019
|
Looks good to me, we'll probably need to set the status of the search as |
I added and set a new |
AnshulMalik
approved these changes
Jan 2, 2019
|
@AnshulMalik What ideas do you have for follow up tweaks? |
|
@darkwing A few
|
|
Great work @Garee ! I love it! |
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First, the search operation is assigned a cancellation function that can be used to stop the search. Next, when a new search is started, it is saved in state so that it can later be cancelled.
The ongoing search is cancelled when:
Fixes #7559
Testing
Other