This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Use AccessibleImage component instead of img in Workers #7639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you @kenjiO ! Not sure how I seemed to have missed that. |
darkwing
approved these changes
Jan 3, 2019
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jan 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7539
Summary of Changes
jsx-a11y/alt-textlint rule from warn to errorjsx-a11y/alt-texterror by usingAccesibleImageinstead ofimgTest Plan
Used inspector to check the rendered output:
Before:
After:
Note: There may be some other issue with this component because clicking on a worker doesn't seem to do anything. This happens both before and after this change so I think it is unrelated to this change.