This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fixes Line Highlight Bug #7768
Merged
Fixes Line Highlight Bug #7768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wldcordeiro
suggested changes
Jan 21, 2019
|
@wldcordeiro Passed both the checks. 👍 |
wldcordeiro
reviewed
Jan 21, 2019
wldcordeiro
approved these changes
Jan 21, 2019
wldcordeiro
reviewed
Jan 21, 2019
| const durationString = style.getPropertyValue( | ||
| "--highlight-line-duration" | ||
| ); | ||
| const duration = |
There was a problem hiding this comment.
Idea, avoid the parseFloat(...) mess by changing the CSS var to 1500ms then just strip out the ms.
There was a problem hiding this comment.
@wldcordeiro But the stripped of "1500" would require a parseInt(...) right?
There was a problem hiding this comment.
@wldcordeiro If it's not a big problem, are we good to go ahead with merging this? 💯
There was a problem hiding this comment.
I really like that idea @wldcordeiro! WIth that we can just do a string replacement of ms
There was a problem hiding this comment.
@darkwing @wldcordeiro On it 👍
|
@darkwing @wldcordeiro Have a look at the changes. I've replaced it with 1500ms and stripped off the last two characters. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7757
Summary of Change
Test Plan
There wasn't any major change in the UI so I am planning to modify the tests later if required.
Demo