Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Improve EventListener UI #7937

Merged
merged 10 commits into from
Feb 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 44 additions & 1 deletion src/components/SecondaryPanes/EventListeners.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
* file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */

.event-listeners-content {
padding: 4px 20px;
padding-top: 4px;
padding-bottom: 4px;
padding-inline-start: 14px;
padding-inline-end: 20px;
}

.event-listeners-content ul {
Expand All @@ -15,6 +18,39 @@
user-select: none;
}

.event-listener-header {
display: flex;
align-items: center;
}

.event-listener-expand {
border: none;
background: none;
padding: 4px 5px;
line-height: 12px;
}

.event-listener-expand:hover {
background: transparent;
}

.event-listener-group input[type="checkbox"] {
margin: 0px;
margin-inline-end: 4px;
}

.event-listener-label {
display: flex;
align-items: center;
padding-inline-start: 2px;
padding-inline-end: 10px;
}

.event-listener-category {
padding: 3px 0px;
line-height: 14px;
}

.event-listeners-content .arrow {
margin-inline-end: 0;
}
Expand All @@ -33,7 +69,14 @@ html[dir="rtl"] .event-listeners-content .arrow.expanded {
margin-inline-start: 30px;
}

.event-listener-name {
line-height: 14px;
padding: 3px 0px;
}

.event-listener-event input {
margin-inline-end: 4px;
margin-inline-start: 0px;
margin-top: 0px;
margin-bottom: 0px;
}
36 changes: 19 additions & 17 deletions src/components/SecondaryPanes/EventListeners.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ class EventListeners extends Component<Props, State> {
}

onCategoryToggle(category, event) {
event.preventDefault();

const { expandedCategories } = this.state;

if (expandedCategories.includes(category)) {
Expand Down Expand Up @@ -102,20 +100,24 @@ class EventListeners extends Component<Props, State> {
);

return (
<label>
<AccessibleImage
className={classnames("arrow", { expanded })}
<div className="event-listener-header">
<button
className="event-listener-expand"
onClick={e => this.onCategoryToggle(category, e)}
/>
<input
type="checkbox"
value={category}
onChange={e => this.onCategoryClick(category, e.target.checked)}
checked={checked}
ref={el => el && (el.indeterminate = indeterminate)}
/>
<span className="event-listener-category">{category}</span>
</label>
>
<AccessibleImage className={classnames("arrow", { expanded })} />
</button>
<label className="event-listener-label">
<input
type="checkbox"
value={category}
onChange={e => this.onCategoryClick(category, e.target.checked)}
checked={checked}
ref={el => el && (el.indeterminate = indeterminate)}
/>
<span className="event-listener-category">{category}</span>
</label>
</div>
);
}

Expand All @@ -134,14 +136,14 @@ class EventListeners extends Component<Props, State> {
const key = getKey(category, eventType);
return (
<li className="event-listener-event" key={key}>
<label>
<label className="event-listener-label">
<input
type="checkbox"
value={key}
onChange={e => this.onEventTypeClick(key, e.target.checked)}
checked={activeEventListeners.includes(key)}
/>
{eventType}
<span className="event-listener-name">{eventType}</span>
</label>
</li>
);
Expand Down