Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GpuExpand by pre-projecting some columns #25

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

firestarman
Copy link
Owner

@firestarman firestarman commented Jan 17, 2024

Some rules in Spark will put non-leaf expressions into Expand projections,
then it can not leverage the GPU tiered projection across the projection lists.

So this PR tries to factor out these expressions and evaluate them before
expanding to avoid duplicate evaluation for semantic-equal (sub) expressions.

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Signed-off-by: Firestarman <firestarmanllc@gmail.com>
@firestarman firestarman merged commit 5fd19a6 into branch-24.02 Jan 19, 2024
37 of 39 checks passed
@firestarman firestarman deleted the expand-improve branch January 19, 2024 08:41
firestarman added a commit that referenced this pull request Jan 22, 2024
Some rules in Spark will put non-leaf expressions into Expand projections,
then it can not leverage the GPU tiered projection across the projection lists.

So this PR tries to factor out these expressions and evaluate them before
expanding to avoid duplicate evaluation for semantic-equal (sub) expressions.

---------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman added a commit that referenced this pull request Jan 25, 2024
Some rules in Spark will put non-leaf expressions into Expand projections,
then it can not leverage the GPU tiered projection across the projection lists.

So this PR tries to factor out these expressions and evaluate them before
expanding to avoid duplicate evaluation for semantic-equal (sub) expressions.

---------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman added a commit that referenced this pull request Jan 25, 2024
Some rules in Spark will put non-leaf expressions into Expand projections,
then it can not leverage the GPU tiered projection across the projection lists.

So this PR tries to factor out these expressions and evaluate them before
expanding to avoid duplicate evaluation for semantic-equal (sub) expressions.

---------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
firestarman added a commit that referenced this pull request Jan 25, 2024
Some rules in Spark will put non-leaf expressions into Expand projections,
then it can not leverage the GPU tiered projection across the projection lists.

So this PR tries to factor out these expressions and evaluate them before
expanding to avoid duplicate evaluation for semantic-equal (sub) expressions.

---------

Signed-off-by: Firestarman <firestarmanllc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant