Trait for default const values #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggyal
force-pushed
the
arbitrary-const-value
branch
2 times, most recently
from
0cff6f8
to
7a650d9
Compare
eggyal
changed the title
|
Perhaps, for maximum interop, this should use https://crates.io/crates/const-default ? |
|
Probably would be best to use the |
Utilises the `const-default` crate (behind a feature gate) to introduce a trait defining an associated constant of the `Self` type. An implementation is provided for `GenericArray`, providing means of constructing default `GenericArray`s in const context. This plugs a gap that exists even after fizyk20#130 was merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the `arr!` macro comes from a type parameter).
eggyal
force-pushed
the
arbitrary-const-value
branch
from
7a650d9
to
3e00487
Compare
|
I've switched to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a trait defining an associated constant of the
Selftype. An implementation is provided forGenericArray, providing means of constructing defaultGenericArrays in const context.This plugs a gap that exists even if #130 is merged, as generic type parameters cannot currently be referenced in const context (e.g. if the repetition length provided to the
arr!macro comes from a type parameter).