Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Symbol" ist undefiniert error in IE 11 #222

Closed
TarikHuber opened this issue Aug 19, 2018 · 6 comments
Closed

"Symbol" ist undefiniert error in IE 11 #222

TarikHuber opened this issue Aug 19, 2018 · 6 comments
Assignees

Comments

@TarikHuber
Copy link

Browser: IE 11 (it works on other browsers I tested like Chrome, Firefox, Edge)
react-toastify version: 4.2.0

Error message:
"Symbol" ist undefiniert

The error is gone wehen falling back to 4.1.0

@TarikHuber TarikHuber changed the title "Symbol" ist undefiniert error ib IE 11 "Symbol" ist undefiniert error in IE 11 Aug 19, 2018
@fkhadra
Copy link
Owner

fkhadra commented Aug 21, 2018

Hello @TarikHuber ,

Thanks for the feedback. I'll fix it asap. Until I fix it, may I suggest you use a Symbol polyfill? https://www.npmjs.com/package/es6-symbol

FYI: The error is due to the fact that I replaced the forEach loop by for of loop.

Sorry for the inconvenience.

@fkhadra fkhadra self-assigned this Aug 21, 2018
@TarikHuber
Copy link
Author

Thx @fkhadra for the fast response. We just use the older version untill the fix arrives. Not a big problem. A Browserstack test that failed showed us the problem. Maybe a solution for this project to. It's free for open source projects.

@fkhadra
Copy link
Owner

fkhadra commented Aug 22, 2018

Perfect. I'll publish the fix during this week.

Indeed, Browerstack is a really good idea. I'll see how to add it to my stack.

@TarikHuber
Copy link
Author

Hi @fkhadra,

Maybe this example of a project with browserstack can help: https://github.com/TarikHuber/react-most-wanted

That is the one that detected this issue. It checks only the version of the project that is already deployed but better than nothing. Need to fix that to to check on localhost at Travis.

@fkhadra
Copy link
Owner

fkhadra commented Aug 29, 2018

Hey @TarikHuber,

Thanks. I already fixed the issue but I wanted to add an additional feature for the next release.

I'm gonna publish a patch release with that fix first. So It fixes the bug first.

fkhadra added a commit that referenced this issue Aug 29, 2018
- Replace for of by forEach to support ie11. For of output Symbol on
babel compilation result.
@fkhadra fkhadra mentioned this issue Aug 29, 2018
@fkhadra
Copy link
Owner

fkhadra commented Aug 29, 2018

Hey @TarikHuber,

I published the v4.2.1. Should be ok now :)

@fkhadra fkhadra closed this as completed Aug 29, 2018
vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
- Replace for of by forEach to support ie11. For of output Symbol on
babel compilation result.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants