Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect z-index in minified css #71

Closed
phil-r opened this issue Nov 8, 2017 · 10 comments
Closed

incorrect z-index in minified css #71

phil-r opened this issue Nov 8, 2017 · 10 comments
Assignees
Labels

Comments

@phil-r
Copy link

phil-r commented Nov 8, 2017

In minified css that can be found here after installation:node_modules/react-toastify/dist/ReactToastify.min.css
z-index on .toastify class is set to 1, although it should be 999

Not a big deal, but it was a bit confusing ;)

@fkhadra
Copy link
Owner

fkhadra commented Nov 9, 2017

Hey @phil-r I had never paid attention, thank you

@fkhadra fkhadra added the bug label Nov 9, 2017
@fkhadra fkhadra added this to the v2.2.1 milestone Nov 19, 2017
@fkhadra fkhadra self-assigned this Nov 19, 2017
@hyperh
Copy link

hyperh commented Nov 20, 2017

Yup getting the same issue, so it appears below some things in my app with higher z-index

@fkhadra
Copy link
Owner

fkhadra commented Nov 20, 2017

Yep, cssnano wanted to optimize the css too much 😁 . I was planning to do other stuff and pushing the fix at the same time.

I'll push the fix for the z-index in a few minutes. Other stuff can wait

fkhadra added a commit that referenced this issue Nov 20, 2017
fkhadra added a commit that referenced this issue Nov 20, 2017
@fkhadra
Copy link
Owner

fkhadra commented Nov 20, 2017

Fix published !

@fkhadra fkhadra closed this as completed Nov 20, 2017
@mrbeen351
Copy link

mrbeen351 commented Nov 23, 2017

Hi @fkhadra , I just update to version 2.2.1 but still got same issue. It still appears below modal pop-up form when using with react-strap form

@fkhadra
Copy link
Owner

fkhadra commented Nov 23, 2017

Hey @mrbeen351,

Did you try to remove npm cache maybe ? If you search the z-index you will see that the z-index is correct.

image

Tell me if it helps.

@mrbeen351
Copy link

mrbeen351 commented Nov 23, 2017

Hi @fkhadra , yes I tried, I realized that z-index of modal form is 1050, but when I change z-index to 1051 or larger it still appears below. I don't know why. I also checked the z-index and saw z-index is 999.
capture

@fkhadra
Copy link
Owner

fkhadra commented Nov 23, 2017

So If I understand you have overwritten the z-index of .toastify and still have the issue?
If yes could you provide a snippet so I can help you to debug?

@mrbeen351
Copy link

Hi @fkhadra , Sorry I think this fault is because of my code. I just create simple example with modal and it displays correctly. Thanks for your kindly support :)

@fkhadra
Copy link
Owner

fkhadra commented Nov 23, 2017

Perfect ! Have a nice day

vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
vasiliydolmatov pushed a commit to vasiliydolmatov/react-toastify that referenced this issue Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants