Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows-pack.yml: update dependencies #3586

Merged
merged 3 commits into from
May 6, 2024

Conversation

Saibamen
Copy link
Contributor

@Saibamen Saibamen commented Apr 28, 2024

@mmahmoudian
Copy link
Member

@Saibamen
Thanks, I was also in the process of updating these. there is one caveat: the actions/upload-artifact from v3 to v4 has some breaking changes and is advised to go through the migration documentation:

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Have you already confirmed the update works without breaking the CI? (I haven't so I'm asking to be sure and also save some time) 😃

@mmahmoudian mmahmoudian mentioned this pull request Apr 28, 2024
@Saibamen
Copy link
Contributor Author

@mmahmoudian
Copy link
Member

It seems we need to go through migration documentation as they failed in artifact upload part

@Saibamen
Copy link
Contributor Author

Saibamen commented May 3, 2024

Please run CI again

@Saibamen
Copy link
Contributor Author

Saibamen commented May 3, 2024

Ready for review

@mmahmoudian
Copy link
Member

@Saibamen Thanks for your persistence and your contribution. I believe now the CI should work based on the migration docs. Let's see in a couple of minutes when the Actions are finished and see if we get any hiccups or errors. If not, I will merge it. Thanks again 👍

@Saibamen
Copy link
Contributor Author

Saibamen commented May 4, 2024

Packaging(Linux) / Build deb on debian-10 armhf (pull_request) has timeout

@mmahmoudian mmahmoudian merged commit 5f30631 into flameshot-org:master May 6, 2024
22 of 23 checks passed
@mmahmoudian
Copy link
Member

@Saibamen Thanks for your persistence, patience, and contribution

@Saibamen Saibamen deleted the patch-1 branch May 7, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants