-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips remain visible after page navigation #2118
Comments
I looked into this because i somehow liked the bug. The other tooltips (for not-badges such as hovering over a user pic in the discussion list) , however, are created like this: I tried to simply remove the container attribute, which fixed this bug. However, the
I'm going to provide a pull request so someone can decide whether this is a suitable fix. |
Another, maybe better possible fix: This would also solve another bug: |
Video of scrolling badge tooltip bug which is also fixed in the second variant # |
…#2166) * Don't use body as tooltip container, allow notification area overflow Badge tooltips are using container: 'body', so they can overflow the notification area. When the user navigates back while a badge tooltip is showing, the tooltip remains visible. This commit removes the body container attribute and instead allows the notificationDropDown to overflow, so badge tooltips aren't cut off. Instead, this adds overflow: hidden to NotificationList. Fixes #2118. * Remove newline
Bug Report
Current Behavior
Tooltips remain on screen when hovering over an element and starting a page navigation.
Steps to Reproduce
(video below)
ALT + Left arrow
They also stack too, meaning you can start a 'who can get the most tooltips on screen at once' competition. I've gotten 11 so far :P
Expected Behavior
The tooltip should probably disappear, along with the rest of the page's content.
Screenshots
https://puu.sh/FvEHo/ff5810b7f5.mp4
Environment
I've reproduced this on other Flarum sites, too.
The text was updated successfully, but these errors were encountered: