Slug transliteration #194 #1148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently slugs are generated using only alphanumeric characters, replacing anything else with a hyphen. I improve Slug function to support some degree of transliteration for non-Latin languages still get slugs.
|
Did you take this code from WordPress? |
|
It looks like you did. Pretty sure that we can't use WordPress code (especially not without attribution) - as WordPress is licensed under GPL. |
|
Plus we still haven't actually decided on a strategy/approach in #194? |
|
Yes I used same function like Wordpress but a little bit modified. |
|
I will close this then. We are more than happy to accept contributions here, but let's agree on a solution in #194 first. And we will have to use a library with a compatible license. Thanks for the initiative! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently slugs are generated using only alphanumeric characters, replacing anything else with a hyphen. I improve Slug function to support some degree of transliteration for non-Latin languages still get slugs.