update postStreamScrubber

[w-4]

fixes the scrubber in the case that posts have margins

Fixes #0000

Fixes the scrubber in case posts have margins.

Changes proposed in this pull request:

The check "top <= viewportTop" is not necessary. it's sufficient to take the index from the first item that passed the previous checks. it's the postStream-item that is first visible in the viewport.

Reviewers should focus on:

Screenshot

Confirmed

• Frontend changes: tested on a local Flarum installation.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[askvortsov1]

Looks good to me.

[dsevillamartin]

@w-4 Can you provide an additional explanation on what this PR solves and how/why it solves it? Thanks 🙂.

[w-4]

@datitisev To be honest, I don't really remember. I quickly tested it locally with and without the fix.
and for me it fixes the following behavior:
go to https://discuss.flarum.org/d/187-word-association-game/1797
press F5 (refresh the page) -> each time it jumps to a different post.

might be related to:
#2088

Edit:
I checked again, it didn't fix it. So not really sure what it does. But I'll leave it in, doesn't hurt.

[askvortsov1]

Thank you for the PR! I'm going to close this for now, we can always revisit it from #2088.