-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View Extender (add namespace) #2134
View Extender (add namespace) #2134
Conversation
… namespaces used in flarum (those are added after extenders are loaded), so I'd like to hold off on that until later.
What do you think about naming the class Hmm... 🤔 ... do we really need other operations? We barely use the concept of namespaces in core, so there's nothing there to replace. And I don't want to suggest removing / replacing other extensions' namespaces is a good thing (or important enough to deal with in one of the bundled extenders). |
I took care of the lazy extending (requested in #2134 (comment)) and the renaming (discussed in #2134 (comment)) in master. Thanks for the PR! 🙌 |
Fixes part of #1891
Changes proposed in this pull request:
Add view extender with addNamespace method. I called it this instead of just ->namespace() in case we want to support prependNamespace, replaceNamespace, etc
Reviewers should focus on:
Do we want to include replaceNamespace here? I think that might be useful. EDIT: Not yet. Flarum's namespaces are loaded after extenders do their thing, so it wouldn't work there, hence, we should hold off on that for now.
Confirmed
composer test
).