Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usages / deprecate path helpers #2155

Merged
merged 7 commits into from
Jun 19, 2020
Merged

Clean up usages / deprecate path helpers #2155

merged 7 commits into from
Jun 19, 2020

Commits on Jun 19, 2020

  1. Write source map without creating temp file 

    Less I/O, and one less place where we access the global path helpers.
    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    347baa8 View commit details
    Browse the repository at this point in the history

  2. Drop useless app_path() helper 

    This was probably taken straight from Laravel. There is no equivalent
concept in Flarum, so this should be safe to remove.
    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    80c09f8 View commit details
    Browse the repository at this point in the history

  3. Deprecate global path helpers 

    Developers using these helpers can inject the `Paths` class instead.
    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    538f66a View commit details
    Browse the repository at this point in the history

  4. Stop storing paths as strings in container

    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    966d034 View commit details
    Browse the repository at this point in the history

  5. Avoid using path helpers from Application class

    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    265b521 View commit details
    Browse the repository at this point in the history

  6. Deprecate path helpers from Application class

    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    bc64494 View commit details
    Browse the repository at this point in the history

  7. Avoid using public_path() in prerequisite check 

    a) The comparison was already outdated, as a different path was passed.
b) We're trying to get rid of these global helpers.
    @franzliedke
    franzliedke committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    fd32230 View commit details
    Browse the repository at this point in the history