Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Alert State, AlertManagerState #2163

Merged
merged 24 commits into from
Jun 30, 2020
Merged

Extract Alert State, AlertManagerState #2163

merged 24 commits into from
Jun 30, 2020

Commits on Jun 26, 2020

  1. Extract Alert State, AlertManagerState

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a38be90 View commit details
    Browse the repository at this point in the history

  2. Make the backend return the proper error code for incorrect password … 

    …in ChangeEmailModal
    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    24eb104 View commit details
    Browse the repository at this point in the history

  3. Modify alert state extraction so that active alerts are stored in an … 

    …object
    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    a150ea4 View commit details
    Browse the repository at this point in the history

  4. Add missing error.alertKey store

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    75f15c0 View commit details
    Browse the repository at this point in the history

  5. Use random integer for alert key instead of date

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    1d541b6 View commit details
    Browse the repository at this point in the history

  6. Allow passing an alert class in alert.show

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    88bf1b2 View commit details
    Browse the repository at this point in the history

  7. Change alertProps to alertAttrs

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    ed7f382 View commit details
    Browse the repository at this point in the history

  8. Revert change of exception thrown when incorrect password on email ch… 

    …ange
    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    c6866a9 View commit details
    Browse the repository at this point in the history

  9. Add in missing formattedError parameter

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    4e34797 View commit details
    Browse the repository at this point in the history

  10. Require an alert state instance to show an alert, put key back into a… 

    …lert state.
    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    887803e View commit details
    Browse the repository at this point in the history

  11. prettify

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    2c915e7 View commit details
    Browse the repository at this point in the history

  12. Show alerts by passing an AlertState

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    22adc26 View commit details
    Browse the repository at this point in the history

  13. Prettify?

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    35afd50 View commit details
    Browse the repository at this point in the history

  14. Encapsulate alertstate, alertmanagerstate

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    7b01596 View commit details
    Browse the repository at this point in the history

  15. Take out unnecessary revert

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    5f394d7 View commit details
    Browse the repository at this point in the history

  16. Use alert state as internal API only

    @askvortsov1 @franzliedke
    askvortsov1 authored and franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    bcaae0b View commit details
    Browse the repository at this point in the history

  17. Make AlertState obsolete

    @franzliedke
    franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    ac48153 View commit details
    Browse the repository at this point in the history

  18. Clean up variable names, doc blocks and imports

    @franzliedke
    franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    03d1bf6 View commit details
    Browse the repository at this point in the history

  19. Fix alert attrs for modal errors

    @franzliedke
    franzliedke committed Jun 26, 2020
    Configuration menu
    Copy the full SHA
    cc0b228 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2020

  1. Rename alert "type" to "componentClass"

    @askvortsov1
    askvortsov1 committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    5e78478 View commit details
    Browse the repository at this point in the history

  2. Add safety check for improper stuff being passed to alerts

    @askvortsov1
    askvortsov1 committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    a61f8a8 View commit details
    Browse the repository at this point in the history

  3. Apply alert BC compliance warning to first argument

    @askvortsov1
    askvortsov1 committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    7638478 View commit details
    Browse the repository at this point in the history

  4. Prettify

    @askvortsov1
    askvortsov1 committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    fb9676c View commit details
    Browse the repository at this point in the history

  5. Reverse order of arguments in alert POJO, as order doesn't matter, an… 

    …d this way it's more consistent
    @askvortsov1
    askvortsov1 committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    8653bf5 View commit details
    Browse the repository at this point in the history