Make scrubber handle have transparent background #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
clarkwinkelmann,
dsevillamartin and
tankerkiller125
tankerkiller125
approved these changes
Jun 30, 2020
clarkwinkelmann
approved these changes
Jul 1, 2020
askvortsov1
deleted the
as/make_scrubber_handle_have_transparent_background
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the scrubber handle's background color is set to the forum's background color. This isn't ideal, because if a non-uniform-colored background is used, it looks awkward. By setting it to transparent, we lose nothing, but make it look better with gradient/picture based backgrounds