-
-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Backend Tests in Transactions #2304
Merged
Merged
Commits on Jan 6, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 843a149 - Browse repository at this point
Copy the full SHA 843a149View commit details -
Configuration menu - View commit details
-
Copy full SHA for a471874 - Browse repository at this point
Copy the full SHA a471874View commit details
Commits on Jan 7, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a08fd3e - Browse repository at this point
Copy the full SHA a08fd3eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3176538 - Browse repository at this point
Copy the full SHA 3176538View commit details -
Configuration menu - View commit details
-
Copy full SHA for cacc8b4 - Browse repository at this point
Copy the full SHA cacc8b4View commit details
Commits on Jan 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 008ec95 - Browse repository at this point
Copy the full SHA 008ec95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a88169 - Browse repository at this point
Copy the full SHA 0a88169View commit details -
Tests: remove prepDb workaround
Previously, the `prepareDatabase` method would directly modify the database, booting the app in the process. This would prevent any extenders from being applied, since `->extend()` has no effect once the app is booted. Since the new implementation of `prepareDatabase` simply registers seed data to be applied during app boot, the workaround of sticking this seed data into `prepDb` is no longer necessary, and seed data common to all test cases in a class can be provided in `setUp`. When needed, app boot is explicitly triggered in individual test cases by calling `$this->app()`.
Configuration menu - View commit details
-
Copy full SHA for ae28001 - Browse repository at this point
Copy the full SHA ae28001View commit details -
Tests: Comply with default permissions
Before transactions, each test class would need to explicitly state starting state for permissions, which made the initial permission configuration somewhat arbitrary. Now, we might as well use the initial state of the default installation. One of the User show_test tests has been commented out until
Configuration menu - View commit details
-
Copy full SHA for c1aa145 - Browse repository at this point
Copy the full SHA c1aa145View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd79a14 - Browse repository at this point
Copy the full SHA fd79a14View commit details -
Some tests need to change settings, but since MemoryCacheSettingsRepository caches settings in-memory, those changes aren't reflected. The new `purgeSettingsCache` removes it from the container, eliminating that cache. For UserTest, we also need to regenerate the display name driver, since that's set statically on boot, before we'll get a change to clear the settings cache.
Configuration menu - View commit details
-
Copy full SHA for 6771b3e - Browse repository at this point
Copy the full SHA 6771b3eView commit details -
Under InnoDB, database entries created in transactions are not processed by fulltext indexes until the transaction is committed. To work around this, cases that test fulltext search have been split off into a separate class that adds and removes seed discussions/posts outside of transactions during setUp/tearDown.
Configuration menu - View commit details
-
Copy full SHA for 4bac667 - Browse repository at this point
Copy the full SHA 4bac667View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5f277e - Browse repository at this point
Copy the full SHA e5f277eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.