update a user's comment count after deleting a discussion #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
approved these changes
Nov 29, 2020
askvortsov1
approved these changes
Nov 29, 2020
askvortsov1
requested review from
dsevillamartin,
clarkwinkelmann,
tankerkiller125 and
luceos
tankerkiller125
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2227
Changes proposed in this pull request:
Remove type hinting from the
updateCommentsCount()function in order to allow it to accept a Post or a Discussion as an argument. This allows you to callupdateCommentsCount()from thewhenDiscussionWasDeleted()listener.The Post class is no longer used in this file, so I removed the use directive at the top of this file.
Reviewers should focus on:
Without union types, there aren't many options for allowing a function to accept two different types of arguments. However, the only other option I could think of other than the one I proposed here is having two arguments with two different types that both default to null. Let me know if there is a better option!
Confirmed
composer test).Also, I noticed that if you delete the last post in the discussion, it deletes the discussion, but it does not update the user's discussion count. Should I create a separate issue for that?