Fixes validation failures of avatars that are jpg/jpeg #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a commit by @fabpot in october, the mimetypes symfony class now re-orders the shortened mimetypes that are returned when looking up based on header mimetype. Our validator uses the first key, pops the prefix off and then matches against our hardcoded array. I've added a constraint to symfony/mime ^5.2.0 which ships with this change. This constraint is fully compatible with our current lineup. In addition I changed the hardcoded array to use the first entry from symfony mime types now `jpg` instead of `jpeg`. This change has been locally tested and confirmed fixed.
luceos
requested review from
tankerkiller125,
clarkwinkelmann and
askvortsov1
clarkwinkelmann
approved these changes
Dec 15, 2020
|
Should we remove |
tankerkiller125
approved these changes
Dec 15, 2020
askvortsov1
approved these changes
Dec 16, 2020
SychO9
pushed a commit
to SychO9/flarum-profile-cover
that referenced
this pull request
Dec 23, 2020
An update of symfony/mime renders the current validator incompatible. This issue is identical to the one from flarum/core's avatar uploader (flarum/framework#2497) and can be fixed in the same way. Tested locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: https://discuss.flarum.org/d/25536-avatar-upload-jpg/47
Due to a commit by @fabpot in october, the mimetypes symfony class
now re-orders the shortened mimetypes that are returned when looking
up based on header mimetype. Our validator uses the first key, pops
the prefix off and then matches against our hardcoded array.
I've added a constraint to symfony/mime ^5.2.0 which ships with this change.
This constraint is fully compatible with our current lineup. In addition
I changed the hardcoded array to use the first entry from symfony mime types
now
jpginstead ofjpeg.This change has been locally tested and confirmed fixed.