Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to dashboard page if extension ID not found #2584

Merged
merged 1 commit into from
Jan 30, 2021

Conversation

dsevillamartin
Copy link
Member

Fixes #2583

Changes proposed in this pull request:

  • Navigate to dashboard route if this.extension is undefined
  • Return '' and null in className and view to prevent accessing this.extension before the route changes

Reviewers should focus on:
Do we want to add/change the returns or add checks when this.extension is used? The user doesn't see the rendered view as it instantly goes to the Dashboard page, but it will still error because Mithril calls the method (but doesn't render it)

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@askvortsov1 askvortsov1 merged commit e137720 into master Jan 30, 2021
@askvortsov1 askvortsov1 deleted the ds/2583-extension-page-fallback branch January 30, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating to extension page using invalid ID breaks admin dashboard
3 participants