Navigate to dashboard page if extension ID not found #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583
Changes proposed in this pull request:
this.extension
is undefined''
andnull
inclassName
andview
to prevent accessingthis.extension
before the route changesReviewers should focus on:
Do we want to add/change the returns or add checks when
this.extension
is used? The user doesn't see the rendered view as it instantly goes to the Dashboard page, but it will still error because Mithril calls the method (but doesn't render it)Confirmed