Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate event helper #2608

Merged
merged 4 commits into from
Mar 2, 2021
Merged

Deprecate event helper #2608

merged 4 commits into from
Mar 2, 2021

Conversation

askvortsov1
Copy link
Sponsor Member

Refs #1796

Changes proposed in this pull request:
Deprecates event helper.

I left in the one used for ListPostsController since that will be removed in #2479

clarkwinkelmann
clarkwinkelmann approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good based on what we discussed 👍

@askvortsov1 askvortsov1 merged commit fc73d47 into master Mar 2, 2021
@askvortsov1 askvortsov1 deleted the as/deprecate-event-helper branch March 2, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@SychO9 SychO9 SychO9 approved these changes

@luceos luceos Awaiting requested review from luceos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@askvortsov1 @tankerkiller125 @clarkwinkelmann @SychO9