Add code scanning workflow to identify common issues #2744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not very familiar with code scanning, but based on the output of the action & the other commit check added by the code scanning itself, it seems to work fine? I would add the matrix language like our PHP testing does so the name: 'Analyze / ${{ matrix.language }}' |
tankerkiller125
approved these changes
Apr 4, 2021
askvortsov1
approved these changes
Apr 8, 2021
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| language: [ 'javascript' ] |
There was a problem hiding this comment.
Should typescript be listed too? I'm assuming its included in javascript,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Adds a GitHub CodeQL code scanning workflow to GitHub Actions.
Fore more info about what this does, please see GitHub's website: https://codeql.github.com/docs/codeql-overview/about-codeql/
Reviewers should focus on: