Include updating of scoped tag permissions #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses flarum#2924 The rename `viewDiscussions` migration introduced for Flarum 1.0 does not take tag scoped permissions into account https://github.com/flarum/core/blob/e92c267cdec46266b633f71c2f41040731cdaf39/migrations/2021_05_10_000000_rename_permissions.php#L17 This adds a new migration to additionally rename `tagX.viewDiscussions` to `tagX.viewForum` Tested locally on an upgrade from core `beta.16` to `1.0.3`
This was referenced Jun 23, 2021
SychO9
reviewed
Jun 24, 2021
|
To clarify, are you suggesting that change for this PR, or to keep the focus on this issue, and open an issue for altering the |
|
Since we're fixing the migration anyway and it's very straightforward, I think it's fine to do here 👍🏼 |
SychO9
approved these changes
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Fixes #2924 **
Changes proposed in this pull request:
The rename
viewDiscussionsmigration introduced for Flarum 1.0 does not take tag scoped permissions into accounthttps://github.com/flarum/core/blob/e92c267cdec46266b633f71c2f41040731cdaf39/migrations/2021_05_10_000000_rename_permissions.php#L17
This fixes the migration to additionally rename
tagX.viewDiscussionstotagX.viewForumAs @clarkwinkelmann suggestion, fixing the current migration rather than introducing a new one so that this will only run for those forums which are yet to update to 1.0
Tested locally on an upgrade from core
beta.16to1.0.3Reviewers should focus on:
Scoped tag permissions are included in the rename of permission
Confirmed
composer test).