Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11Y] Improve accessibility for discussion reply count on post stream #3090

Merged
merged 14 commits into from
Oct 27, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Oct 2, 2021

Fixes #2664

Changes proposed in this pull request:

  • Add new accessibility label to reply count
    • "2 unread replies. Mark replies as read"
    • "8 replies"
  • Use <button> element when Mark as read feature is active, otherwise use <span>

Reviewers should focus on:

Nothing in particular.

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Oct 2, 2021
@davwheat davwheat added this to the 1.2 milestone Oct 2, 2021
@davwheat davwheat self-assigned this Oct 2, 2021
@davwheat davwheat removed this from the 1.2 milestone Oct 2, 2021
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davwheat
Copy link
Member Author

davwheat commented Oct 9, 2021

I forgot that I already added a screenreader-only class when I made checkboxes focusable in #3014, so I've removed the one I added in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] New reply counter is focusable when not acting as a button
3 participants