Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better post loading support #3100

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Better post loading support #3100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion js/src/forum/components/Post.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import Dropdown from '../../common/components/Dropdown';
import PostControls from '../utils/PostControls';
import listItems from '../../common/helpers/listItems';
import ItemList from '../../common/utils/ItemList';
import LoadingIndicator from '../../common/components/LoadingIndicator';

/**
* The `Post` component displays a single post. The basic post template just
Expand All @@ -21,6 +22,9 @@ export default class Post extends Component {
oninit(vnode) {
super.oninit(vnode);

/**
* May be set by subclasses.
*/
this.loading = false;

/**
Expand All @@ -30,6 +34,7 @@ export default class Post extends Component {
* @type {SubtreeRetainer}
*/
this.subtree = new SubtreeRetainer(
() => this.loading,
() => this.attrs.post.freshness,
() => {
const user = this.attrs.post.user();
Expand All @@ -50,7 +55,7 @@ export default class Post extends Component {
return (
<article {...attrs}>
<div>
{this.content()}
{this.loading ? <LoadingIndicator /> : this.content()}
<aside className="Post-actions">
<ul>
{listItems(this.actionItems().toArray())}
Expand Down