Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use an extensible document title driver implementation #3109

Merged
merged 3 commits into from
Nov 8, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 15, 2021

Replaces #2957

Changes proposed in this pull request:
Uses a driver implementation to make the title of the frontend document.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

# Conflicts:
#	src/Frontend/FrontendServiceProvider.php
@SychO9 SychO9 merged commit f9f398b into master Nov 8, 2021
@SychO9 SychO9 deleted the sm/extend-document-title branch November 8, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants