Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add priority order to controls #3165

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Add priority order to controls #3165

merged 1 commit into from
Nov 16, 2021

Conversation

imorland
Copy link
Member

When extending sidebarItems, it is currently not possible to easily define where new components should appear in the ItemList due to no priority being set on controls.

Changes proposed in this pull request:
Set an initial priority on the controls item to 100

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added this to the 1.2 milestone Nov 16, 2021
@SychO9 SychO9 merged commit c120f28 into flarum:master Nov 16, 2021
@imorland imorland deleted the im/sidebar branch November 16, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants