fix: don't duplicate path in URL to post on subdirectory installs. #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feels like this issue solves one instance of a problem, a problem that can cascade into other areas including 3rd party extensions. What is exactly the cause? Is baseUrl sometimes the domain + path and sometimes just the path? |
|
@luceos |
davwheat
requested changes
Mar 23, 2022
| return app.forum.attribute('baseUrl') + app.route.post(post); | ||
| // URL.hostname transformation is necessary to avoid duplicating | ||
| // path in subdirectory installs. | ||
| return URL(app.forum.attribute('baseUrl')).hostname + app.route.post(post); |
There was a problem hiding this comment.
This will not keep URLs which contain ports, nor the protocol. We should use .origin instead.
Suggested change
| return URL(app.forum.attribute('baseUrl')).hostname + app.route.post(post); | |
| return new URL(app.forum.attribute('baseUrl')).origin + app.route.post(post); |
`baseUrl` includes the path portion of the url, as does `basePath`, which is included in `app.route.x` function outputs. The `baseOrigin` (with no path component at all) should be used instead.
askvortsov1
force-pushed
the
as/fix-subdir-post-url
branch
from
463af9a
to
339234b
Compare
SychO9
approved these changes
Apr 6, 2022
davwheat
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.