fix: slug transliteration assuming the language is always en
#3387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Right now slugs are generated from transliterated title, but always assuming
en
language. So if a forum is using another language with different characters like Chinese, transliteration doesn't work.This PR passes the forum's current locale code to the
slug
method of laravel, to properly transliterate into the forum's language.Reviewers should focus on:
The problem however is if a forum uses multiple languages it won't work because laravel's
slug
doesn't detect language on its own, so for example on discuss if someone created a discussion with a Japanese title, the slug will not work, but I believe this is still better than not.Necessity
Confirmed
composer test
).