Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and description to tags and tag pages #154

Conversation

askvortsov1
Copy link
Sponsor Member

No description provided.

@askvortsov1
Copy link
Sponsor Member Author

This fully covers #119, which can probably be closed if this is accepted.

@luceos
Copy link
Member

luceos commented Feb 13, 2020

@askvortsov1 linking issues/pr's can only be done from the body (not the subject) unless it's in the same repo (I think), so: flarum/tags#72

@luceos luceos changed the title Companion PR to https://github.com/flarum/tags/pull/72. Companion PR to flarum/tags#72. Feb 13, 2020
@luceos luceos changed the title Companion PR to flarum/tags#72. Companion PR to flarum/tags#72 Feb 13, 2020
@askvortsov1
Copy link
Sponsor Member Author

@askvortsov1 linking issues/pr's can only be done from the body (not the subject) unless it's in the same repo (I think), so: flarum/tags#72

Thanks!

Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please include at least the context of what you're changing in the PR title. Cross references can go in the description. 🙊

locale/flarum-tags.yml Outdated Show resolved Hide resolved
@askvortsov1
Copy link
Sponsor Member Author

Thank you!

Please include at least the context of what you're changing in the PR title. Cross references can go in the description.

Noted, will do going forward!

@askvortsov1 askvortsov1 changed the title Companion PR to flarum/tags#72 Add title and description to tags and tag pages Mar 3, 2020
@franzliedke
Copy link
Contributor

I've tweaked the keys a bit, but used your texts, all in master.

When you have the text, feel free to read our extensive documentation on internationalization, especially this handy appendix. 😀

It's the awesome legacy of our former internationalization expert, who unfortunately can no longer contribute.

askvortsov1 pushed a commit that referenced this pull request Mar 11, 2022
askvortsov1 pushed a commit that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants