Use a notification driver with the new channel extender

[SychO9]

Part Of flarum/framework#2432

Hmm, do we want to create a job for it and queue it ? it used to be executed inside the SendNotificationJob job.

[askvortsov1]

Hmm, do we want to create a job for it and queue it ? it used to be executed inside the SendNotificationJob job.

I'd lean towards yes on this one, but @flarum/core might disagree. Lets wait for a decision on flarum/framework#2432 first though.

[tankerkiller125]

I'm going to say Queue it, Pretty much my personal opinion is to always queue things unless it's critical to execute immediately. Notifications of any kind in my opinion are always queueable.

[clarkwinkelmann]

Queue definitely make sense. Technically we could implement NotificationDriverInterface::send to always be called from a queue in core for all notifications... But would we want that? Though I think this might create an issue if an extension actually needs to call its code without a queue.

Other question is one job per notification, or one job that loops through the users?

[SychO9]

Queue definitely make sense. Technically we could implement NotificationDriverInterface::send to always be called from a queue in core for all notifications... But would we want that? Though I think this might create an issue if an extension actually needs to call its code without a queue.

Yea I don't think we'd want to force it on a queue.

Other question is one job per notification, or one job that loops through the users?

I'd say one job that loops through the users.