Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meta title to following page #23

Merged
merged 3 commits into from
Jun 3, 2020

Conversation

askvortsov1
Copy link
Sponsor Member

No description provided.

@dsevillamartin
Copy link
Member

Is there any reason as to why this code is going in config instead of init? Looks like we put app.setTitle() calls in the init method in core.

@askvortsov1
Copy link
Sponsor Member Author

Is there any reason as to why this code is going in config instead of init? Looks like we put app.setTitle() calls in the init method in core.

I don't think we do: https://github.com/flarum/core/blob/0d208dc4437c0cc551c556d2c2cc7c12bda369ae/js/src/forum/components/IndexPage.js#L98

@dsevillamartin
Copy link
Member

@askvortsov1
Copy link
Sponsor Member Author

I'm seeing that sometimes it's also in show. Should we standardize the location?

@dsevillamartin
Copy link
Member

@askvortsov1 Show is called from init I think, or outside calls.

@askvortsov1
Copy link
Sponsor Member Author

Should we standardize the location? I'm not too familiar with frontend convention

Copy link
Contributor

@franzliedke franzliedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review our documentation about standard key format and change the key accordingly.

My change here may serve as inspiration.

@askvortsov1
Copy link
Sponsor Member Author

Please review our documentation about standard key format and change the key accordingly.

My change here may serve as inspiration.

Done, thanks!

@franzliedke franzliedke merged commit b206dc9 into flarum:master Jun 3, 2020
franzliedke pushed a commit to flarum/lang-english that referenced this pull request Jun 3, 2020
@askvortsov1 askvortsov1 deleted the as/add_meta_title branch June 4, 2020 02:33
askvortsov1 added a commit to flarum/lang-english that referenced this pull request Mar 11, 2022
askvortsov1 added a commit that referenced this pull request Mar 11, 2022
askvortsov1 added a commit to flarum/lang-english that referenced this pull request May 10, 2022
askvortsov1 added a commit that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants