-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added meta title to following page #23
Conversation
Is there any reason as to why this code is going in |
I don't think we do: https://github.com/flarum/core/blob/0d208dc4437c0cc551c556d2c2cc7c12bda369ae/js/src/forum/components/IndexPage.js#L98 |
Ah, looks like we put it in either (https://github.com/flarum/core/blob/68afdd21aee3b2032aaf89052bf3951c164df01d/js/src/forum/components/SettingsPage.js#L16-L21). |
I'm seeing that sometimes it's also in show. Should we standardize the location? |
@askvortsov1 Show is called from |
Should we standardize the location? I'm not too familiar with frontend convention |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review our documentation about standard key format and change the key accordingly.
My change here may serve as inspiration.
Done, thanks! |
No description provided.