Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests #14

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(await findFirstColumnTokens()).to.eql(['Number', 'Text', 'Geo point', 'Date']);

expect(await findFirstDocViewerTokens()).to.eql([
'Keyword',
'Keyword',
'Keyword',
'Number',
Expand All @@ -182,7 +183,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'Text',
'Number',
'IP address',
'Text',
]);
});

Expand Down
4 changes: 2 additions & 2 deletions test/functional/apps/discover/group3/_doc_viewer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.findFieldByNameInDocViewer('geo');

await retry.waitFor('first updates', async () => {
return (await find.allByCssSelector('.kbnDocViewer__fieldName')).length === 5;
return (await find.allByCssSelector('.kbnDocViewer__fieldName')).length === 4;
});

await PageObjects.discover.findFieldByNameInDocViewer('.s');
Expand All @@ -82,7 +82,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.findFieldByNameInDocViewer('relatedContent image');

await retry.waitFor('updates', async () => {
return (await find.allByCssSelector('.kbnDocViewer__fieldName')).length === 5;
return (await find.allByCssSelector('.kbnDocViewer__fieldName')).length === 4;
});
});

Expand Down
6 changes: 3 additions & 3 deletions test/functional/apps/discover/group6/_sidebar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await retry.waitFor('second updates', async () => {
return (
(await PageObjects.unifiedFieldList.getSidebarAriaDescription()) ===
'10 available fields. 3 empty fields. 3 meta fields.'
'10 available fields. 3 empty fields. 4 meta fields.'
);
});

Expand Down Expand Up @@ -336,7 +336,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.toggleSidebarSection('meta');
expect(
(await PageObjects.unifiedFieldList.getSidebarSectionFieldNames('meta')).join(', ')
).to.be('_id, _index, _score');
).to.be('_id, _ignored, _index, _score');

expect(await PageObjects.unifiedFieldList.getSidebarAriaDescription()).to.be(
INITIAL_FIELD_LIST_SUMMARY
Expand Down Expand Up @@ -373,7 +373,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.toggleSidebarSection('meta');
expect(
(await PageObjects.unifiedFieldList.getSidebarSectionFieldNames('meta')).join(', ')
).to.be('_id, _index, _score');
).to.be('_id, _ignored, _index, _score');

// Expand Unmapped section
await PageObjects.unifiedFieldList.toggleSidebarSection('unmapped');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'@tags.raw',
'@timestamp',
'_id',
'_ignored',
'_index',
'_score',
'_source',
'_test',
];

expect(await PageObjects.settings.getFieldNames()).to.eql(unfilteredFields);
Expand All @@ -107,10 +107,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'@tags.raw',
'@timestamp',
'_id',
'_ignored',
'_index',
'_score',
'_source',
'agent',
];

expect(await PageObjects.settings.getFieldNames()).to.eql(unfilteredFields);
Expand Down Expand Up @@ -181,10 +181,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'keyword',
'date',
'_id',
'_ignored',
'_index',
'',
'_source',
'text',
]);

// set other filters to check if they get reset after pressing the button
Expand Down
1,790 changes: 895 additions & 895 deletions x-pack/test/functional/apps/discover/__snapshots__/reporting.snap

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export default function ({ getService }: FtrProviderContext) {

it('includes all unmapped fields to the report', async () => {
const csvFile = await generateCsvReportWithUnmapped(['*']);
expect((csvFile as string).length).to.be(120);
expect((csvFile as string).length).to.be(139);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down Expand Up @@ -337,7 +337,7 @@ export default function ({ getService }: FtrProviderContext) {
const { path: downloadPath } = JSON.parse(res.text) as { path: string };
await reportingAPI.waitForJobToFinish(downloadPath);
const csvFile = await reportingAPI.getCompletedJobOutput(downloadPath);
expect((csvFile as string).length).to.be(5381);
expect((csvFile as string).length).to.be(5400);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});

Expand Down Expand Up @@ -383,7 +383,7 @@ export default function ({ getService }: FtrProviderContext) {
const { path: downloadPath } = JSON.parse(res.text) as { path: string };
await reportingAPI.waitForJobToFinish(downloadPath);
const csvFile = await reportingAPI.getCompletedJobOutput(downloadPath);
expect((csvFile as string).length).to.be(4440);
expect((csvFile as string).length).to.be(4459);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down Expand Up @@ -673,7 +673,7 @@ export default function ({ getService }: FtrProviderContext) {
const { path: downloadPath } = JSON.parse(res.text) as { path: string };
await reportingAPI.waitForJobToFinish(downloadPath);
const csvFile = await reportingAPI.getCompletedJobOutput(downloadPath);
expect((csvFile as string).length).to.be(329);
expect((csvFile as string).length).to.be(356);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down Expand Up @@ -734,7 +734,7 @@ export default function ({ getService }: FtrProviderContext) {
const { path: downloadPath } = JSON.parse(res.text) as { path: string };
await reportingAPI.waitForJobToFinish(downloadPath);
const csvFile = await reportingAPI.getCompletedJobOutput(downloadPath);
expect((csvFile as string).length).to.be(4388);
expect((csvFile as string).length).to.be(4407);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ export default function ({ getService }: FtrProviderContext) {

it('includes all unmapped fields to the report', async () => {
const csvFile = await generateCsvReportWithUnmapped(['*']);
expect((csvFile as string).length).to.be(124);
expect((csvFile as string).length).to.be(143);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down Expand Up @@ -341,7 +341,7 @@ export default function ({ getService }: FtrProviderContext) {
);
await reportingAPI.waitForJobToFinish(res.path);
const csvFile = await reportingAPI.getCompletedJobOutput(res.path);
expect((csvFile as string).length).to.be(1267140);
expect((csvFile as string).length).to.be(1270683);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});

Expand Down Expand Up @@ -387,7 +387,7 @@ export default function ({ getService }: FtrProviderContext) {
);
await reportingAPI.waitForJobToFinish(res.path);
const csvFile = await reportingAPI.getCompletedJobOutput(res.path);
expect((csvFile as string).length).to.be(914755);
expect((csvFile as string).length).to.be(918298);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down Expand Up @@ -677,7 +677,7 @@ export default function ({ getService }: FtrProviderContext) {
);
await reportingAPI.waitForJobToFinish(res.path);
const csvFile = await reportingAPI.getCompletedJobOutput(res.path);
expect((csvFile as string).length).to.be(329);
expect((csvFile as string).length).to.be(356);
expectSnapshot(createPartialCsv(csvFile)).toMatch();
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.toggleSidebarSection('meta');
expect(
(await PageObjects.unifiedFieldList.getSidebarSectionFieldNames('meta')).join(', ')
).to.be('_id, _index, _score');
).to.be('_id, _ignored, _index, _score');

expect(await PageObjects.unifiedFieldList.getSidebarAriaDescription()).to.be(
INITIAL_FIELD_LIST_SUMMARY
Expand Down Expand Up @@ -326,7 +326,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.unifiedFieldList.toggleSidebarSection('meta');
expect(
(await PageObjects.unifiedFieldList.getSidebarSectionFieldNames('meta')).join(', ')
).to.be('_id, _index, _score');
).to.be('_id, _ignored, _index, _score');

// Expand Unmapped section
await PageObjects.unifiedFieldList.toggleSidebarSection('unmapped');
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'@tags.raw',
'@timestamp',
'_id',
'_ignored',
'_index',
'_score',
'_source',
'_test',
];

expect(await PageObjects.settings.getFieldNames()).to.eql(unfilteredFields);
Expand All @@ -110,10 +110,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'@tags.raw',
'@timestamp',
'_id',
'_ignored',
'_index',
'_score',
'_source',
'agent',
];

expect(await PageObjects.settings.getFieldNames()).to.eql(unfilteredFields);
Expand Down Expand Up @@ -185,10 +185,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
'keyword',
'date',
'_id',
'_ignored',
'_index',
'',
'_source',
'text',
]);

// set other filters to check if they get reset after pressing the button
Expand Down
Loading