Log request url for eth_sendRawTransaction #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
reviewed
May 29, 2024
metachris
approved these changes
May 29, 2024
Co-authored-by: Chris Hager <chris@linuxuser.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Log request url for eth_sendRawTransaction
⛱ Motivation and Context
Clients have been quite error prone when it comes to setting URL parameters. Currently there isn't one source of truth we can check as we don't log or record in DB the actual URL used by user. Having logging of the exact URL used would greatly facilitate debugging.
✅ I have run these commands
make lintmake testgo mod tidy