chore(golang): Update to Go 1.22 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention this also updates geth to 1.14.7 which is the minimum supported version for go 1.21 and higher. |
metachris
reviewed
Aug 5, 2024
| @@ -1,17 +1,20 @@ | |||
| module github.com/flashbots/rpc-endpoint | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
is it necessary to make the minimum version v1.21?
There was a problem hiding this comment.
Ya, versions older than 1.21 choke on the new toolchain directive below that go 1.22 adds. I'm actually surprised that the Go team didn't consider this, I feel like the toolchain directive should've only been added for newer go versions but I can't find a way to do that.
Basically running into the same issue as: golang/go#65847 (comment)
metachris
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Update
go.modto go 1.21+ format w/toolchaindirective and update Docker container to use go 1.22.⛱ Motivation and Context
Running
go mod tidyw/ go 1.22 or higher wants to rewrite thego.modwith the newtoolchaindirective, which causes go 1.20 to die with an unrecognized directive error.📚 References
https://go.dev/doc/toolchain
✅ I have run these commands
make lintmake testgo mod tidy