Skip to content

Commit

Permalink
Addressing custom box-box intersection
Browse files Browse the repository at this point in the history
This does several things:

1. Modifies the "correctness" of box-box intersection:
  a. Addresses the interpretation of the contact position (as per
     issue #258); the contact position lies between the two surfaces.
  b. Correct the sign on the penetration depth so that colliding
     objects report positive penetration depth.
2. Refactors box-box intersection code:
  a. Removes redundant implementation to limit repeated bugs. This
     encompasses completely redundant function implementations as well
     as unnecessary duplicatio in branches.
  b. Add additional documentation/todos on the implementation.
  c. Replace the `fudge2` parameter with something more reasoned.
3. Adds unit tests confirming the behavior.
  • Loading branch information
SeanCurtis-TRI committed Mar 1, 2018
1 parent 4304833 commit 3ac84ce
Show file tree
Hide file tree
Showing 4 changed files with 560 additions and 597 deletions.
Loading

0 comments on commit 3ac84ce

Please sign in to comment.