Fixes a nasty bug in propagateBVHFrontListCollisionRecurse() #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causing test_fcl_frontlist to fail on Windows. The bug is platform independent though so I don't know why it passes anywhere. Also did some minor code cleanup (std::fabs -> std::abs).
|
With this merged there are only two remaining test failures on windows:
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing
test_fcl_frontlistto seg fault on Windows. The bug is platform independent though so it definitely wasn't working right anywhere. Windows happened to access unreadable memory; probably it picked up garbage elsewhere. Apparently the test case isn't too fussy!Also did some minor code cleanup (std::fabs -> std::abs, fix a typo).
@panjia1983, do you know how the test case could be improved so that it would have noticed this?