Hide coveralls repository token #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coveralls repository token is supposed to be private because it grants write access. To hide it while it keeps working:
COVERALLS_REPO_TOKENfrom.travis.ymlCOVERALLS_REPO_TOKENto the new token on Travis as a hidden environment variableas we did in DART thanks to @mkoval.
Also, I changed the coverage test to be done in linux/debug builds instead of adding a separate build to reduce the whole Travis test. It could be better the coverage test is done only for gcc, but Travis doesn't provide environment variable to detect the compiler. I'm open to hearing a better way to do this.