Replace non-portable M_PI with constants::pi() #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCurtis-TRI
force-pushed
the
PR_remove_non_portable_M_PI
branch
from
2ec3137
to
05db219
Compare
|
@traversaro can you confirm this works for you? |
SeanCurtis-TRI
commented
Feb 24, 2020
There was a problem hiding this comment.
+@sherm1 for both reviews.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @sherm1)
sherm1
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Thanks! 
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This indeed fixes the problem for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently an M_PI snuck in after #264. This reversed it back out.
resolves #448
This change is