Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate uninstall target #612

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

csculley
Copy link
Contributor

@csculley csculley commented Dec 4, 2023

Hello, I'm using this library with another library that creates an uninstall target, which was causing errors, since it already exists. I've added guards for this uninstall target according to Kitware's suggestions here.

Please let me know if anything needs to be changed in this PR! Thank you!


This change is Reviewable

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, thanks for the fix

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @csculley)

@sherm1 sherm1 merged commit b03987c into flexible-collision-library:master Dec 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants