Updates to tcl cmds using 8.6.0 manual #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
November 23, 2019 07:34
added 25 commits
December 3, 2019 11:55
Of course these updates were done to the best of my knowledge/documentation/lack of consisten documentation Refactors will clearly be done in the future As of this update, currently skipped or UNDONE completers areas are: unload yield yieldto transchan try my self safe registry (because it requires a package) oo::create oo::object oo::define oo::copy oo::class next,nextto namespace [this was already not working in the original, I half-assed added a few missing commands (eg ensemble isnt complete at all) but it still doesnt work.] memory - because i needs tcl to be compile with debugging on lsearch interp info
That missing brace ruined everything as it was falling back to the default completer so verify check all other manual completers again since last major change
Hecka too tired to attempt this conundrum and everything else is pretty much done. We can use the old method until they deprecate it anyways
bovine
reviewed
Jul 27, 2020
| return "" | ||
| switch -- $pos { | ||
| 1 { | ||
| return [TryFromList $text {-encoding <filenName>}] |
| proc complete(update) {text start end line pos mod} { | ||
| switch -- $pos { | ||
| switch -- ${pos} { |
There was a problem hiding this comment.
The braces around the variable name are unnecessary here since there is no parsing ambiguity without them.
| proc complete(variable) {text start end line pos mod} { | ||
| set modulo [expr {$pos % 2}] | ||
| set modulo [expr $pos % 2] |
There was a problem hiding this comment.
The braces around the expr argument were intentional and provide additional performance and security.
| @@ -3571,7 +4389,7 @@ namespace eval tclreadline { | |||
| if {"#" == [string index $one 0] || [regexp {^[0-9]*$} $one]} { | |||
| incr virtual_pos | |||
| } | |||
| switch [expr {$virtual_pos % 2}] { | |||
| switch [expr $virtual_pos % 2] { | |||
| # Best I can do to notify user of option to body or continue list | ||
| 3 { return [DisplayHints {<body> ?varlist?}] } | ||
| default { | ||
| set modulo [expr $pos % 2] |
| return "" | ||
| } else { | ||
| return [Quote $value $text] | ||
| return [Quote $value ${text}] |
There was a problem hiding this comment.
Braces are unnecessary for this variable reference..
Comment on lines
+4350
to
+4351
| if {"#" == [string index ${one} 0] || [regexp {^[0-9]*$} ${one}]} { | ||
| return [CompleteFromList ${text} [CommandCompletion ${text}]] |
There was a problem hiding this comment.
Braces are unnecessary for the variable references throughout this proc.
bovine
reviewed
Jul 28, 2020
Comment on lines
+3219
to
+3220
| ensemble { return [CompleteFromList $text {create | ||
| configure exists] } |
There was a problem hiding this comment.
Seems like you have a mismatch in closing braces here
|
Will review later when i have free time and make the changes that you suggest @bovine . Thank you |
|
closing due to lack of activity. If you intend to resubmit this, try to keep your edits more limited in scope to make the approval easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to tclreadline with accompany of 8.6.0 online tcl manual.
Completers Listed in Manual Completely Not Implemented/updated
yield
yieldto
transchan
try
self
registry (requires a Windows package)
oo::create
oo::object
oo::define
oo::copy
oo::class
my
next,nextto
memory - (because it needs tcl to be compile with debugging on)
lsearch
coroutine
chan - never had a completer
dict - never had a completer
Other's to examine for various reasons
apply - anonymous function prob cant complete intuitively??
expr - It's current completer had everything moved to
mathfuncand seems to be unsupported in 8.6???file - a few optional options can be added
dde - Requires Windows
resource - Requires Mac
switch - index var and matchvar options need to recognize and account for the
indexvar <integer>andmatchvar <$var>continue - not really neccesary
close - didnt complete the two-argument form since "only sockets and command pipelines support half-close."
unload/load - doesnt guess the last few entries of the syntax
packagenameoriterpnamespace - [this was already not working in the original, I added a few missing subcmds (eg ensemble isnt complete at all) but it still doesnt work.]