Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added music notes and header for music_player #1191

Closed
wants to merge 2 commits into from

Conversation

leeroywking
Copy link
Contributor

What's new

  • Created header file
  • Moved Note and duration information into header file
  • Added complete note list for Octaves 3,4,5,6,7,8
  • Added entries for get_note_name case statement
  • Added entry for get_note_len_name case statement

Verification

  • Ran docker-compose exec dev make
  • Flashed firmware to flipper zero using qflipper
  • Ran music player app to verify functionality has not changed
  • Verify new notes using the following song definition (replace existing in code)
  • const MelodyEventRecord melody_start[] = {{C3,L8},{C_3,L8},{D3,L8},{D_3,L8},{E3,L8},{F3,L8},{F_3,L8},{G3,L8},{G_3,L8},{A3,L8},{A_3,L8},{B3,L8},{C4,L8},{C_4,L8},{D4,L8},{D_4,L8},{E4,L8},{F4,L8},{F_4,L8},{G4,L8},{G_4,L8},{A4,L8},{A_4,L8},{B4,L8},{C5,L8},{C_5,L8},{D5,L8},{D_5,L8},{E5,L8},{F5,L8},{F_5,L8},{G5,L8},{G_5,L8},{A5,L8},{A_5,L8},{B5,L8},{C6,L8},{C_6,L8},{D6,L8},{D_6,L8},{E6,L8},{F6,L8},{F_6,L8},{G6,L8},{G_6,L8},{A6,L8},{A_6,L8},{B6,L8},{C7,L8},{C_7,L8},{D7,L8},{D_7,L8},{E7,L8},{F7,L8},{F_7,L8},{G7,L8},{G_7,L8},{A7,L8},{A_7,L8},{B7,L8},{C8,L8},{C_8,L8},{D8,L8},{D_8,L8},{E8,L8},{F8,L8},{F_8,L8},{G8,L8},{G_8,L8},{A8,L8},{A_8,L8},{B8,L8}};

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

skotopes commented May 3, 2022

Currently working on full redesign of music player: #1189

@skotopes skotopes closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants