Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode RAW recordings #1667

Closed
wants to merge 16 commits into from
Closed

Decode RAW recordings #1667

wants to merge 16 commits into from

Conversation

qistoph
Copy link
Contributor

@qistoph qistoph commented Aug 26, 2022

What's new

Flipper_SubGhz_RAW_decoder-2022-08-26_21 36 43

  • Add decode to the More menu of saved RAW recordings
  • Reuses the SubGhz Receiver View
  • Tweaked this view to support:
    • Live versus File view
    • File progress (instead of Config button) in left bottom
  • Reuses the SubGhz Receiver Info scene
  • Add subghz_file_encoder_worker_get_text_progress

The icon could use a little improvement. Unfortunately I'm not a fluent designer.
assets/icons/SubGhz/Decoding_123x52.png

Verification

  • Make a RAW recording of signals supported by available decoders
  • Save the RAW recording
  • From a saved RAW recording, open the More menu
  • Select the Decode option
  • See how Flipper decodes the recorded signals

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Member

Hi. We already have it as a cli command and intentionally decided not to make GUI version of it.

Is there any real life use cases for it?

@azaitsev
Copy link

@skotopes as for me it's cool to have it in gui

@qistoph
Copy link
Contributor Author

qistoph commented Aug 29, 2022

While new protocol support is still being developed, it's a great way to test support for previously recorded codes.

I also feel, like @azaitsev, it should be part of the interface. It will also help beginner users to more easily understand and try-out the relationship between raw recordings and their decoded counter parts.

@white-gecko
Copy link

white-gecko commented Aug 29, 2022

Hi. We already have it as a cli command and intentionally decided not to make GUI version of it.

Is there any real life use cases for it?
@skotopes

Could you please point to the respective CLI?

@qistoph
Copy link
Contributor Author

qistoph commented Aug 29, 2022

Could you please point to the respective CLI?

Checkout my comment in the related issue: #1638 (comment)

@RogueMaster

This comment was marked as abuse.

@HenryDorsettC4se
Copy link

I second this. Some of us cannot use the cli often and, some of us, cannot use the phone app at all (I do not have enough money to buy a new phone and my old one is not supported :/)
The GUI/Onboard possibility to decode raw encodings is awesome imo.

@jagotu
Copy link

jagotu commented Sep 6, 2022

I also very much like this feature. Unlike the CLI command, it creates an output in a format you can save. With the CLI, you'd have to take the text output and manually convert it into the .sub file format.

For me this feature is useful where you want to limit the time "in the field", for example when recording doorbells, as you can only trigger the bell twice (record raw and then try if the recording works), and then use this UI to decode the recording or even decode it later once the protocol gets added. If you were to start with non-raw recordings and the protocol was unsupported, you increase the number of recording attempts you have to make.

All-in-all for me this is a very nice additition to the FW.

@hedger hedger added the Sub-GHz Sub-GHz-related label Sep 19, 2022
@hedger hedger added UI Affects UI New Feature Contains an IMPLEMENTATION of a new feature labels Sep 19, 2022
@skotopes
Copy link
Member

skotopes commented Oct 8, 2022

Hi. Sorry for long delay.

We started to split SubGhz application into specialized apps and can accept this PR as external application. Would you like to try to make this feature separate app?

@skotopes skotopes self-assigned this Oct 8, 2022
Copy link
Member

@skotopes skotopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in PR thread

@skotopes
Copy link
Member

I'll move this PR to draft, please un-draft when you complete.

@skotopes skotopes marked this pull request as draft December 10, 2022 19:12
@CodyTolene
Copy link

Any updates on this?

@skotopes
Copy link
Member

@CodyTolene at this point the best option to implement whole thing as external application.

@skotopes skotopes closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature Contains an IMPLEMENTATION of a new feature Sub-GHz Sub-GHz-related UI Affects UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants