Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auth/cookie fixes for OIDC login #1274

Merged
merged 4 commits into from
Jan 17, 2023
Merged

fix: auth/cookie fixes for OIDC login #1274

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea1b732
fix: wip auth/cookie fixes
markphelps Jan 15, 2023
d7c9c36
chore: add tests for server auth fixes
markphelps Jan 16, 2023
93065b7
chore: add one more test for callbackURL
markphelps Jan 16, 2023
8ccc668
Merge branch 'main' into auth-fixes
markphelps Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add one more test for callbackURL
  • Loading branch information
@markphelps
markphelps committed Jan 16, 2023
commit 93065b7b6a8a10f50df9d976c1e16cdfdf8a305e
5 changes: 5 additions & 0 deletions internal/server/auth/method/oidc/server_internal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ func TestCallbackURL(t *testing.T) {
host string
want string
}{
{
name: "plain",
host: "localhost",
want: "localhost/auth/v1/method/oidc/foo/callback",
},
{
name: "no trailing slash",
host: "localhost:8080",
Expand Down