WIP

config/local.yml

@@ -5,3 +5,10 @@ db:
   url: file:flipt.db
   migrations:
     path: ./config/migrations
+
+ui:
+  enabled: false
+
+cors:
+  enabled: true
+  allowed_origins: "*"

server/segment.go

@@ -85,6 +85,8 @@ func (s *Server) CreateConstraint(ctx context.Context, req *flipt.CreateConstrai
 		return nil, emptyFieldError("operator")
 	}
 
+	// TODO: test for empty value if operator ! [EMPTY, NOT_EMPTY, PRESENT, NOT_PRESENT]
+
 	return s.SegmentStore.CreateConstraint(ctx, req)
 }
 
@@ -106,6 +108,8 @@ func (s *Server) UpdateConstraint(ctx context.Context, req *flipt.UpdateConstrai
 		return nil, emptyFieldError("operator")
 	}
 
+	// TODO: test for empty value if operator ! [EMPTY, NOT_EMPTY, PRESENT, NOT_PRESENT]
+
 	return s.SegmentStore.UpdateConstraint(ctx, req)
 }
 

storage/evaluator.go

@@ -421,8 +421,6 @@ func validate(c constraint) error {
 }
 
 func matchesString(c constraint, v string) bool {
-	value := c.Value
-
 	switch c.Operator {
 	case opEmpty:
 		return len(strings.TrimSpace(v)) == 0
@@ -434,6 +432,8 @@ func matchesString(c constraint, v string) bool {
 		return false
 	}
 
+	value := c.Value
+
 	switch c.Operator {
 	case opEQ:
 		return value == v

ui/src/components/Segments/Segment.vue

@@ -164,7 +164,11 @@
                 </BSelect>
               </b-field>
               <b-field v-show="hasValue(newConstraint.operator)" label="Value">
-                <b-input v-model="newConstraint.value" placeholder="Value" />
+                <b-input
+                  v-model="newConstraint.value"
+                  placeholder="Value"
+                  required
+                />
               </b-field>
               <div class="field is-grouped">
                 <div class="control">
@@ -248,6 +252,7 @@
                 <b-input
                   v-model="selectedConstraint.value"
                   placeholder="Value"
+                  required
                 />
               </b-field>
               <div class="field is-grouped">
@@ -396,10 +401,28 @@ export default {
       return this.segment.key && this.segment.name;
     },
     canAddConstraint() {
-      return this.newConstraint.property && this.newConstraint.type;
+      let valid =
+        this.newConstraint.property &&
+        this.newConstraint.type &&
+        this.newConstraint.operator;
+
+      if (this.hasValue(this.newConstraint.operator)) {
+        return valid && this.newConstraint.value;
+      }
+
+      return valid;
     },
     canUpdateConstraint() {
-      return this.selectedConstraint.property && this.selectedConstraint.type;
+      let valid =
+        this.selectedConstraint.property &&
+        this.selectedConstraint.type &&
+        this.selectedConstraint.operator;
+
+      if (this.hasValue(this.selectedConstraint.operator)) {
+        return valid && this.selectedConstraint.value;
+      }
+
+      return valid;
     }
   },
   mounted() {

ui/src/services/api.js

@@ -1,5 +1,10 @@
 import axios from "axios";
 
+let host =
+  process.env.NODE_ENV === "production"
+    ? window.location.host
+    : "localhost:8080";
+
 export const Api = axios.create({
-  baseURL: "//" + window.location.host + "/api/v1/"
+  baseURL: "//" + host + "/api/v1/"
 });