Batch evaluate ignore disabled flags #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Jan 14, 2021
There was a problem hiding this comment.
makes sense @vic3lord , would you mind adding a test to validate the new behavior? also one comment/question
|
Thanks @vic3lord! I'll create a new release this weekend. I'm wondering if we should just not return errors when trying to evaluate a disabled flag in general (even for a single/non-batch evaluate call)? |
|
I agree, we can discuss this further but I wanted to be conservative since you are the maintainer, I didn't want to assume design decisions on my own. We use flags internally as kill switches for new features that are not UI A/B testing. Might make sense to not return an error in this case. Thanks again for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using BatchEvaluate the entire call is canceled with an error once it encounters the first disabled flag.
In order to be able to disable a flag without failing the entire request I added a new ErrDisabled and checked when doing BatchEvaluate.
This way you can continue batching flags with the possibility to disable flags.